From: "flichtenheld (Code Review)" Date: Mon, 18 Mar 2024 16:30:01 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <1b288677817dd4b2204e977f61ffc13373b7e9f2-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="3jyMQS7DsA0="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Allow the TLS session to send out TLS alerts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --3jyMQS7DsA0= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/449?usp=3Demail ) Change subject: Allow the TLS session to send out TLS alerts ...................................................................... Patch Set 6: Code-Review+2 (2 comments) Patchset: PS6: Looks good to me, but did not test it. File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/449/comment/46b395cc_6e433008 : PS6, Line 3236: msg(D_TLS_ERRORS, "TLS Error: generate_key_= expansion failed"); While here, can we fix the error message, please? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/449?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0ad48915004ddee587e97c8ed190ba8ee989e48d Gerrit-Change-Number: 449 Gerrit-PatchSet: 6 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Mon, 18 Mar 2024 16:30:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --3jyMQS7DsA0= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

Patch set 6:Code-Review +2=

Vi= ew Change

2 comments:

  • Patchset:

  • File src/openvpn/ssl.c:=

    • Patch Set #6, Line= 3236: = msg(D_TLS_ERRORS, "TLS Error: generate_key_expansion failed");

      While he= re, can we fix the error message, please?

To view= , visit c= hange 449. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0ad48915004ddee587e97c8ed19= 0ba8ee989e48d
Gerrit-Change-Number: 449
Gerrit-PatchSet: 6
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Comment-Date: Mon, 18 Mar 2024 16:30:01= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--3jyMQS7DsA0=--