From: "Kamble, Sagar A" Subject: Re: [PATCH v4 11/26] drm/i915/slpc: Update sysfs/debugfs interfaces for frequency parameters Date: Thu, 15 Sep 2016 16:11:45 +0530 Message-ID: <1b6134be-dc82-e137-67df-feb27acfe0b5@intel.com> References: <1473425505-3890-1-git-send-email-sagar.a.kamble@intel.com> <1473425505-3890-12-git-send-email-sagar.a.kamble@intel.com> <20160909171302.GM20027@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 356B76E84D for ; Thu, 15 Sep 2016 10:42:03 +0000 (UTC) In-Reply-To: <20160909171302.GM20027@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org, Tom O'Rourke List-Id: intel-gfx@lists.freedesktop.org CgpPbiA5LzkvMjAxNiAxMDo0MyBQTSwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+IE9uIEZyaSwgU2Vw IDA5LCAyMDE2IGF0IDA2OjIxOjMwUE0gKzA1MzAsIFNhZ2FyIEFydW4gS2FtYmxlIHdyb3RlOgo+ PiBGcm9tOiBUb20gTydSb3Vya2UgPFRvbS5PJ1JvdXJrZUBpbnRlbC5jb20+Cj4+Cj4+IFdoZW4g U0xQQyBpcyBjb250cm9sbGluZyByZXF1ZXN0ZWQgZnJlcXVlbmN5LCB0aGUgcnBzLmN1cl9mcmVx Cj4+IHZhbHVlIGlzIG5vdCB1c2VkIHRvIG1ha2UgdGhlIGZyZXF1ZW5jeSByZXF1ZXN0Lgo+Pgo+ PiBSZXF1ZXN0ZWQgZnJlcXVlbmN5IGZyb20gcmVnaXN0ZXIgUlBOU1dSRVEgaGFzIHRoZSB2YWx1 ZQo+PiBtb3N0IHJlY2VudGx5IHJlcXVlc3RlZCBieSBTTFBDIGZpcm13YXJlLiBBZGRpbmcgbmV3 IHN5c2ZzCj4+IGludGVyZmFjZSBndF9yZXFfZnJlcV9taHogdG8ga25vdyB0aGlzIHZhbHVlLgo+ PiBTTFBDIHJlcXVlc3RlZCB2YWx1ZSBuZWVkcyB0byBiZSBtYWRlIGF2YWlsYWJsZSB0byBpOTE1 IHdpdGhvdXQKPj4gcmVhZGluZyBSUE5TV1JFUS4KPj4KPj4gdjE6IFJlcGxhY2UgSEFTX1NMUEMg d2l0aCBpbnRlbF9zbHBjX2FjdGl2ZSAoUGF1bG8pCj4+ICAgICAgQXZvaWQgbWFnaWMgbnVtYmVy cyAoTmljaykKPj4gICAgICBVc2UgYSBmdW5jdGlvbiBmb3IgcmVwZWF0ZWQgY29kZSAoSm9uKQo+ Pgo+PiB2MjogQWRkICJTTFBDIEFjdGl2ZSIgdG8gaTkxNV9mcmVxdWVuY3lfaW5mbyBvdXRwdXQg YW5kCj4+ICAgICAgZG9uJ3QgdXBkYXRlIGN1cl9mcmVxIGFzIGl0IGlzIGRyaXZlciBpbnRlcm5h bCByZXF1ZXN0LiAoQ2hyaXMpCj4+Cj4+IHYzOiBSZW1vdmluZyBzeXNmcyBpbnRlcmZhY2UgZ3Rf cmVxX2ZyZXFfbWh6IG91dCBvZiB0aGlzIHBhdGNoCj4+ICAgICAgZm9yIHByb3BlciBkaXZpc2lv biBvZiBmdW5jdGlvbmFsaXR5LiAoU2FnYXIpCj4+Cj4+IHY0OiBpZGxlX2ZyZXEsIGJvb3N0X2Zy ZXEgYXJlIGFsc28gbm90IHVzZWQgd2l0aCBTTFBDLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBUb20g TydSb3Vya2UgPFRvbS5PJ1JvdXJrZUBpbnRlbC5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6IFNhZ2Fy IEFydW4gS2FtYmxlIDxzYWdhci5hLmthbWJsZUBpbnRlbC5jb20+Cj4+IC0tLQo+PiAgIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jIHwgMjQgKysrKysrKysrKysrKysrKysrLS0t LS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9zeXNmcy5jICAgfCAgMyArKysKPj4g ICAyIGZpbGVzIGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4+Cj4+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4+IGluZGV4IDAyYjYyN2UuLjcxYmNlMzIg MTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4+IEBAIC0xMDgzLDYgKzEw ODMsOSBAQCBzdGF0aWMgaW50IGk5MTVfZnJlcXVlbmN5X2luZm8oc3RydWN0IHNlcV9maWxlICpt LCB2b2lkICp1bnVzZWQpCj4+ICAgCj4+ICAgCWludGVsX3J1bnRpbWVfcG1fZ2V0KGRldl9wcml2 KTsKPj4gICAKPj4gKwlpZiAoaW50ZWxfc2xwY19hY3RpdmUoZGV2X3ByaXYpKQo+PiArCQlzZXFf cHV0cyhtLCAiU0xQQyBBY3RpdmVcbiIpOwo+PiArCj4+ICAgCWlmIChJU19HRU41KGRldl9wcml2 KSkgewo+PiAgIAkJdTE2IHJndnN3Y3RsID0gSTkxNV9SRUFEMTYoTUVNU1dDVEwpOwo+PiAgIAkJ dTE2IHJndnN0YXQgPSBJOTE1X1JFQUQxNihNRU1TVEFUX0lMSyk7Cj4+IEBAIC0xMjUwLDE1ICsx MjUzLDIxIEBAIHN0YXRpYyBpbnQgaTkxNV9mcmVxdWVuY3lfaW5mbyhzdHJ1Y3Qgc2VxX2ZpbGUg Km0sIHZvaWQgKnVudXNlZCkKPj4gICAJCXNlcV9wcmludGYobSwgIk1heCBvdmVyY2xvY2tlZCBm cmVxdWVuY3k6ICVkTUh6XG4iLAo+PiAgIAkJCSAgIGludGVsX2dwdV9mcmVxKGRldl9wcml2LCBk ZXZfcHJpdi0+cnBzLm1heF9mcmVxKSk7Cj4+ICAgCj4+IC0JCXNlcV9wcmludGYobSwgIkN1cnJl bnQgZnJlcTogJWQgTUh6XG4iLAo+PiAtCQkJICAgaW50ZWxfZ3B1X2ZyZXEoZGV2X3ByaXYsIGRl dl9wcml2LT5ycHMuY3VyX2ZyZXEpKTsKPj4gKwkJaWYgKCFpbnRlbF9zbHBjX2FjdGl2ZShkZXZf cHJpdikpIHsKPiBKdXN0IGtlZXAgcHJpbnRpbmcgdGhlbSwgd2UgaGF2ZSB0aGUgYmFubmVyIHVw ZnJvbnQsIGFuZCBiZWluZyBhYmxlIHRvCj4gdHJhY2sgYW5kIGNvbXBhcmUgaW50ZXJuYWwgdmFs dWVzIHZzIGh3IHN0YXRlIGlzIHN0aWxsIGltcG9ydGFudC4gKEFuZAo+IHRoZSBvcmRlcmluZyB3 YXMgZmFpcmx5IGludGVudGlvbmFsLikKY3VyX2ZyZXEsIGlkbGVfZnJlcSwgYm9vc3RfZnJlcSB3 aWxsIG5vdCBiZSBhcHBsaWNhYmxlIHdpdGggU0xQQy4KV2l0aCBTTFBDIHdlIHNob3VsZCByZWx5 IG9uIHZhbHVlIGZyb20gUlBOU1dSRVEgZm9yIGN1cl9mcmVxLgo+Cj4+ICsJCQlzZXFfcHJpbnRm KG0sICJDdXJyZW50IGZyZXE6ICVkIE1IelxuIiwKPj4gKwkJCQkgICBpbnRlbF9ncHVfZnJlcShk ZXZfcHJpdiwKPj4gKwkJCQkJCSAgZGV2X3ByaXYtPnJwcy5jdXJfZnJlcSkpOwo+PiArCQkJc2Vx X3ByaW50ZihtLCAiSWRsZSBmcmVxOiAlZCBNSHpcbiIsCj4+ICsJCQkJICAgaW50ZWxfZ3B1X2Zy ZXEoZGV2X3ByaXYsCj4+ICsJCQkJCQkgIGRldl9wcml2LT5ycHMuaWRsZV9mcmVxKSk7Cj4+ICsJ CQlzZXFfcHJpbnRmKG0sICJCb29zdCBmcmVxOiAlZCBNSHpcbiIsCj4+ICsJCQkJICAgaW50ZWxf Z3B1X2ZyZXEoZGV2X3ByaXYsCj4+ICsJCQkJCQkgIGRldl9wcml2LT5ycHMuYm9vc3RfZnJlcSkp Owo+PiArCQl9Cj4+ICsKPj4gICAJCXNlcV9wcmludGYobSwgIkFjdHVhbCBmcmVxOiAlZCBNSHpc biIsIGNhZ2YpOwo+PiAtCQlzZXFfcHJpbnRmKG0sICJJZGxlIGZyZXE6ICVkIE1IelxuIiwKPj4g LQkJCSAgIGludGVsX2dwdV9mcmVxKGRldl9wcml2LCBkZXZfcHJpdi0+cnBzLmlkbGVfZnJlcSkp Owo+PiAgIAkJc2VxX3ByaW50ZihtLCAiTWluIGZyZXE6ICVkIE1IelxuIiwKPj4gICAJCQkgICBp bnRlbF9ncHVfZnJlcShkZXZfcHJpdiwgZGV2X3ByaXYtPnJwcy5taW5fZnJlcSkpOwo+PiAtCQlz ZXFfcHJpbnRmKG0sICJCb29zdCBmcmVxOiAlZCBNSHpcbiIsCj4+IC0JCQkgICBpbnRlbF9ncHVf ZnJlcShkZXZfcHJpdiwgZGV2X3ByaXYtPnJwcy5ib29zdF9mcmVxKSk7Cj4+ICAgCQlzZXFfcHJp bnRmKG0sICJNYXggZnJlcTogJWQgTUh6XG4iLAo+PiAgIAkJCSAgIGludGVsX2dwdV9mcmVxKGRl dl9wcml2LCBkZXZfcHJpdi0+cnBzLm1heF9mcmVxKSk7Cj4+ICAgCQlzZXFfcHJpbnRmKG0sCj4+ IEBAIC0yMzE1LDYgKzIzMjQsOSBAQCBzdGF0aWMgaW50IGk5MTVfcnBzX2Jvb3N0X2luZm8oc3Ry dWN0IHNlcV9maWxlICptLCB2b2lkICpkYXRhKQo+PiAgIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 ID0gJmRldl9wcml2LT5kcm07Cj4+ICAgCXN0cnVjdCBkcm1fZmlsZSAqZmlsZTsKPj4gICAKPj4g KwlpZiAoaW50ZWxfc2xwY19hY3RpdmUoZGV2X3ByaXYpKQo+PiArCQlyZXR1cm4gLUVOT0RFVjsK Pj4gKwo+PiAgIAlzZXFfcHJpbnRmKG0sICJSUFMgZW5hYmxlZD8gJWRcbiIsIGRldl9wcml2LT5y cHMuZW5hYmxlZCk7Cj4+ICAgCXNlcV9wcmludGYobSwgIkdQVSBidXN5PyAlcyBbJXhdXG4iLAo+ PiAgIAkJICAgeWVzbm8oZGV2X3ByaXYtPmd0LmF3YWtlKSwgZGV2X3ByaXYtPmd0LmFjdGl2ZV9l bmdpbmVzKTsKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfc3lzZnMu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfc3lzZnMuYwo+PiBpbmRleCAxMDEyZWVlLi4w MjBkNjRlIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3N5c2ZzLmMK Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9zeXNmcy5jCj4+IEBAIC0yOTksNiAr Mjk5LDkgQEAgc3RhdGljIHNzaXplX3QgZ3RfY3VyX2ZyZXFfbWh6X3Nob3coc3RydWN0IGRldmlj ZSAqa2RldiwKPj4gICB7Cj4+ICAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9 IGtkZXZfbWlub3JfdG9faTkxNShrZGV2KTsKPj4gICAKPj4gKwlpZiAoaW50ZWxfc2xwY19hY3Rp dmUoZGV2X3ByaXYpKQo+PiArCQlyZXR1cm4gLUVOT0RFVjsKPiBPaywgSSBoYWQgYSB0aG91Z2h0 IHRoYXQgd2UgYWxsb3dlZCB0aGUgdXNlciB0byBkaXJlY3RseSBzZXQgY3VyIGZyZXEsCj4gYnV0 IHdlIGRvbid0Lgo+IC1DaHJpcwo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK