From: "MaxF (Code Review)" Date: Thu, 27 Mar 2025 15:43:08 +0000 In-Reply-To: References: Reply-To: max@...2606..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <1b6c84cad12ab6a160b901dfc24ff0956fa029d7-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="ChHFTV+PtYg="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Fix mbed TLS key exporter functionality in 3.6.x and cmake List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: flichtenheld , openvpn-devel --ChHFTV+PtYg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/open= vpn/+/920?usp=3Demail ) Change subject: Fix mbed TLS key exporter functionality in 3.6.x and cmake ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: Tiny bug in the error message, but the change makes sense. What I don't understand is how this gets triggered. I looked at configure.a= c again and as far as I understand it, it does the following (starting from= line 1041): Set have_export_keying_material to "yes". Check if mbedtls_ssl_conf_export_keys_ext_cb exists. If not, check if mbedtls_ssl_set_export_keys_cb exists. If that doesn't exist either, set have_export_keying_material to "no". File src/openvpn/ssl_mbedtls.c: http://gerrit.openvpn.net/c/openvpn/+/920/comment/1220b775_cb2a77f6 : PS1, Line 257: HAVE_MBEDTLS_SSL_CONF_EXPORT_KEYS_EXT_CB The second one should be HAVE_MBEDTLS_SSL_SET_EXPORT_KEYS_CB -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/920?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: If38e80e268dc0ee7e57de2c175c5b4db0ce55ed0 Gerrit-Change-Number: 920 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: MaxF Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Thu, 27 Mar 2025 15:43:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --ChHFTV+PtYg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

View C= hange

2 comments:

    =
  • Patchset:

    • Patch Set #1:

      Tiny bug in the error message, but the change mak= es sense.

      Wha= t I don't understand is how this gets triggered. I looked at configure.= ac again and as far as I understand it, it does the following (starting fro= m line 1041):

      Set have_export_keying_material to "yes".
      Check if mbedtls_ss= l_conf_export_keys_ext_cb exists.
      If not, check if mbedtls_ssl_set_expor= t_keys_cb exists.
      If that doesn't exist either, set have_export_keyi= ng_material to "no".

  • File src/openvpn/ssl_mbedtls.c:

    • Patch Set #1, Line 257: HAVE_MBEDTLS_SSL_CONF_EXPORT_KEYS_EXT_CB=

      The second o= ne should be HAVE_MBEDTLS_SSL_SET_EXPORT_KEYS_CB

= To view, visit change 920. To unsubscribe, or for help writing mail filters, vis= it settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If38e80e268dc0ee7e57de2c175c= 5b4db0ce55ed0
Gerrit-Change-Number: 920
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: MaxF <max@...2606...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Thu, 27 Mar 2025 15:43:08= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--ChHFTV+PtYg=--