From: Markus Elfring Subject: Re: drm/imx: Checking a kmemdup() call in imx_pd_bind() Date: Mon, 7 Oct 2019 09:44:23 +0200 Message-ID: <1b86ce88-ec28-0710-b624-e1eded248da2@web.de> References: <20191004190938.15353-1-navid.emamdoost@gmail.com> <540321eb-7699-1d51-59d5-dde5ffcb8fc4@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Navid Emamdoost , Kangjie Lu , Stephen McCamant Cc: kernel@pengutronix.de, David Airlie , Shawn Guo , Sascha Hauer , kernel-janitors@vger.kernel.org, LKML , dri-devel@lists.freedesktop.org, linux-imx@nxp.com, Daniel Vetter , Philipp Zabel , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Navid Emamdoost List-Id: dri-devel@lists.freedesktop.org > I agree with you, kmemdup may fail so a null check seems necessary there. Would this place (and similar ones) be pointed out for further considerations also by the source code analysis tool which your software research group seems to be developing? https://github.com/umnsec/cheq/ Regards, Markus