From: Oleksandr Subject: Re: [PATCH V3 2/5] xen/arm: drivers: scif: Extend driver to handle other interfaces Date: Mon, 15 Apr 2019 14:30:44 +0300 Message-ID: <1c0b4b09-7d7b-97a7-eecd-b809ea79523c@gmail.com> References: <1554718489-11318-1-git-send-email-olekstysh@gmail.com> <1554718489-11318-3-git-send-email-olekstysh@gmail.com> <3370f03e-3d4d-7d01-3783-6475b110860c@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hFzp2-0007Zd-Rd for xen-devel@lists.xenproject.org; Mon, 15 Apr 2019 11:30:48 +0000 Received: by mail-lf1-x144.google.com with SMTP id z9so12762058lfh.6 for ; Mon, 15 Apr 2019 04:30:47 -0700 (PDT) In-Reply-To: <3370f03e-3d4d-7d01-3783-6475b110860c@arm.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Julien Grall , xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , sstabellini@kernel.org List-Id: xen-devel@lists.xenproject.org Ck9uIDE0LjA0LjE5IDE5OjU1LCBKdWxpZW4gR3JhbGwgd3JvdGU6Cj4gSGkgT2xla3NhbmRyLAoK SGkgSnVsaWVuCgoKPgo+IE9uIDQvOC8xOSAxMToxNCBBTSwgT2xla3NhbmRyIFR5c2hjaGVua28g d3JvdGU6Cj4+IEZyb206IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5r b0BlcGFtLmNvbT4KPj4KPj4gRXh0ZW5kIGRyaXZlciB0byBiZSBhYmxlIHRvIGhhbmRsZSBvdGhl ciBTQ0lGKFgpIGNvbXBhdGlibGUKPj4gaW50ZXJmYWNlcyBhcyB3ZWxsLiBUaGVzZSBpbnRlcmZh Y2VzIGhhdmUgbG90IGluIGNvbW1vbiwKPj4gYnV0IG1vc3RseSBkaWZmZXIgaW4gb2Zmc2V0cyBh bmQgYml0cyBmb3Igc29tZSByZWdpc3RlcnMuCj4KPiBDYW4geW91IGJyaWVmbHkgZXhwbGFpbiBp biB0aGUgY29tbWl0IG1lc3NhZ2Ugd2hhdCBkaWZmZXJzPwoKU3VyZQoKCj4KPiBbLi4uXQo+Cj4+ IEBAIC02NSwxMyArMTAwLDE2IEBAIHN0YXRpYyB2b2lkIHNjaWZfdWFydF9pbnRlcnJ1cHQoaW50 IGlycSwgdm9pZCAKPj4gKmRhdGEsIHN0cnVjdCBjcHVfdXNlcl9yZWdzICpyZWdzKQo+PiDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzZXJpYWxfcnhfaW50ZXJydXB0KHBvcnQsIHJlZ3MpOwo+ PiDCoCDCoMKgwqDCoMKgwqDCoMKgwqAgLyogRXJyb3IgSW50ZXJydXB0ICovCj4+IC3CoMKgwqDC oMKgwqDCoCBpZiAoIHN0YXR1cyAmIFNDSUZfRVJST1JTICkKPj4gLcKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgc2NpZl93cml0ZXcodWFydCwgU0NJRl9TQ0ZTUiwgflNDSUZfRVJST1JTKTsKPj4gLcKg wqDCoMKgwqDCoMKgIGlmICggc2NpZl9yZWFkdyh1YXJ0LCBTQ0lGX1NDTFNSKSAmIFNDTFNSX09S RVIgKQo+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzY2lmX3dyaXRldyh1YXJ0LCBTQ0lGX1ND TFNSLCAwKTsKPj4gK8KgwqDCoMKgwqDCoMKgIGlmICggc3RhdHVzICYgcGFyYW1zLT5lcnJvcl9t YXNrICkKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc2NpZl93cml0ZXcodWFydCwgcGFyYW1z LT5zdGF0dXNfcmVnLCB+cGFyYW1zLT5lcnJvcl9tYXNrKTsKPj4gK8KgwqDCoMKgwqDCoMKgIGlm ICggcGFyYW1zLT5vdmVycnVuX3JlZyAhPSBwYXJhbXMtPnN0YXR1c19yZWcgKQo+Cj4gQmVsb3cg eW91IHdpbGwgd3JpdGUgdGhlIHNhbWUgcmVnaXN0ZXIgdHdpY2UgaWYgb3ZlcnJ1bl9yZWcgPT0g Cj4gc3RhdHVzX3JlZyAoc2VlIHNjaWZfdWFydF9pbml0X3ByZWlycSkuIFdvdWxkIHRoZXJlIGJl IGFueSBpc3N1ZSBpZiAKPiB5b3UgZG8gdGhlIHNhbWUgaGVyZT8KCkkgZGlkbid0IGV4cGVjdCBh bnkgaXNzdWUgdG8gd3JpdGUgdGhlIHNhbWUgcmVnaXN0ZXIgdHdpY2UgZHVyaW5nIAppbml0aWFs aXphdGlvbiB0byBzaW1wbGlmeSB0aGUgY29kZSwgdGhhdCB3aHkgSSBhZ3JlZWQgdG8gcmVtb3Zl IHRoZSAKY2hlY2sgaW4gVjEuCgpCdXQgSSBhbSBub3Qgc3VyZSBhYm91dCBkb2luZyBzbyBoZXJl LiBXZSBjb3VsZCBzaW1wbGlmeSB0aGUgY29kZSBieSAKanVzdCByZW1vdmluZyAiaWYgKCBwYXJh bXMtPm92ZXJydW5fcmVnICE9IHBhcmFtcy0+c3RhdHVzX3JlZyApIiwKCmJ1dCB3ZSB3b3VsZCBu ZWVkIHRvIGRvIGV4dHJhIG9wZXJhdGlvbiBmb3IgU0NJRkEgd2hpY2ggaGFzIG92ZXJydW5fcmVn IAo9PSBzdGF0dXNfcmVnLgoKV2hhdCB3YXkgZG8geW91IHByZWZlcj8KCgo+Cj4gU2ltaWxhcmx5 LCB5b3Ugc2VlbSB0byBkZWZpbmUgb3ZlcnJ1bl9tYXNrIGZvciBTQ0lGQSAoc2VlIG5leHQgcGF0 Y2gpIAo+IGJ1dCBpdCB3aWxsIG5ldmVyIGJlIHVzZWQgYXMsIEFGQUlDVCwgc3RhdHVzX3JlZyA9 PSBvdmVycnVuX3JlZy4KPj4gK8KgwqDCoMKgwqDCoMKgIHsKPj4gK8KgwqDCoMKgwqDCoMKgwqDC oMKgwqAgaWYgKCBzY2lmX3JlYWR3KHVhcnQsIHBhcmFtcy0+b3ZlcnJ1bl9yZWcpICYgCj4+IHBh cmFtcy0+b3ZlcnJ1bl9tYXNrICkKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBz Y2lmX3dyaXRldyh1YXJ0LCBwYXJhbXMtPm92ZXJydW5fcmVnLCAKPj4gfnBhcmFtcy0+b3ZlcnJ1 bl9tYXNrKTsgPiArwqDCoMKgwqDCoMKgwqAgfQo+PiDCoCDCoMKgwqDCoMKgwqDCoMKgwqAgY3Ry bCA9IHNjaWZfcmVhZHcodWFydCwgU0NJRl9TQ1NDUik7Cj4+IC3CoMKgwqDCoMKgwqDCoCBzdGF0 dXMgPSBzY2lmX3JlYWR3KHVhcnQsIFNDSUZfU0NGU1IpICYgflNDRlNSX1RFTkQ7Cj4+ICvCoMKg wqDCoMKgwqDCoCBzdGF0dXMgPSBzY2lmX3JlYWR3KHVhcnQsIHBhcmFtcy0+c3RhdHVzX3JlZykg JiB+U0NGU1JfVEVORDsKPj4gwqDCoMKgwqDCoMKgwqDCoMKgIC8qIElnbm9yZSBuZXh0IGZsYWcg aWYgVFggSW50ZXJydXB0IGlzIGRpc2FibGVkICovCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAo ICEoY3RybCAmIFNDU0NSX1RJRSkgKQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzdGF0 dXMgJj0gflNDRlNSX1RERkU7Cj4+IEBAIC04MSwxMiArMTE5LDEzIEBAIHN0YXRpYyB2b2lkIHNj aWZfdWFydF9pbnRlcnJ1cHQoaW50IGlycSwgdm9pZCAKPj4gKmRhdGEsIHN0cnVjdCBjcHVfdXNl cl9yZWdzICpyZWdzKQo+PiDCoCBzdGF0aWMgdm9pZCBfX2luaXQgc2NpZl91YXJ0X2luaXRfcHJl aXJxKHN0cnVjdCBzZXJpYWxfcG9ydCAqcG9ydCkKPj4gwqAgewo+PiDCoMKgwqDCoMKgIHN0cnVj dCBzY2lmX3VhcnQgKnVhcnQgPSBwb3J0LT51YXJ0Owo+PiArwqDCoMKgIGNvbnN0IHN0cnVjdCBw b3J0X3BhcmFtcyAqcGFyYW1zID0gdWFydC0+cGFyYW1zOwo+PiDCoCDCoMKgwqDCoMKgIC8qCj4+ IMKgwqDCoMKgwqDCoCAqIFdhaXQgdW50aWwgbGFzdCBiaXQgaGFzIGJlZW4gdHJhbnNtaXR0ZWQu IFRoaXMgaXMgbmVlZGVkIGZvciAKPj4gYSBzbW9vdGgKPj4gwqDCoMKgwqDCoMKgICogdHJhbnNp dGlvbiB3aGVuIHdlIGNvbWUgZnJvbSBlYXJseSBwcmludGsKPj4gwqDCoMKgwqDCoMKgICovCj4+ IC3CoMKgwqAgd2hpbGUgKCAhKHNjaWZfcmVhZHcodWFydCwgU0NJRl9TQ0ZTUikgJiBTQ0ZTUl9U RU5EKSApOwo+PiArwqDCoMKgIHdoaWxlICggIShzY2lmX3JlYWR3KHVhcnQsIHBhcmFtcy0+c3Rh dHVzX3JlZykgJiBTQ0ZTUl9URU5EKSApOwo+PiDCoCDCoMKgwqDCoMKgIC8qIERpc2FibGUgVFgv UlggcGFydHMgYW5kIGFsbCBpbnRlcnJ1cHRzICovCj4+IMKgwqDCoMKgwqAgc2NpZl93cml0ZXco dWFydCwgU0NJRl9TQ1NDUiwgMCk7Cj4+IEBAIC05NSwxMCArMTM0LDEwIEBAIHN0YXRpYyB2b2lk IF9faW5pdCBzY2lmX3VhcnRfaW5pdF9wcmVpcnEoc3RydWN0IAo+PiBzZXJpYWxfcG9ydCAqcG9y dCkKPj4gwqDCoMKgwqDCoCBzY2lmX3dyaXRldyh1YXJ0LCBTQ0lGX1NDRkNSLCBTQ0ZDUl9SRlJT VCB8IFNDRkNSX1RGUlNUKTsKPj4gwqAgwqDCoMKgwqDCoCAvKiBDbGVhciBhbGwgZXJyb3JzIGFu ZCBmbGFncyAqLwo+PiAtwqDCoMKgIHNjaWZfcmVhZHcodWFydCwgU0NJRl9TQ0ZTUik7Cj4+IC3C oMKgwqAgc2NpZl93cml0ZXcodWFydCwgU0NJRl9TQ0ZTUiwgMCk7Cj4+IC3CoMKgwqAgc2NpZl9y ZWFkdyh1YXJ0LCBTQ0lGX1NDTFNSKTsKPj4gLcKgwqDCoCBzY2lmX3dyaXRldyh1YXJ0LCBTQ0lG X1NDTFNSLCAwKTsKPj4gK8KgwqDCoCBzY2lmX3JlYWR3KHVhcnQsIHBhcmFtcy0+c3RhdHVzX3Jl Zyk7Cj4+ICvCoMKgwqAgc2NpZl93cml0ZXcodWFydCwgcGFyYW1zLT5zdGF0dXNfcmVnLCAwKTsK Pj4gK8KgwqDCoCBzY2lmX3JlYWR3KHVhcnQsIHBhcmFtcy0+b3ZlcnJ1bl9yZWcpOwo+PiArwqDC oMKgIHNjaWZfd3JpdGV3KHVhcnQsIHBhcmFtcy0+b3ZlcnJ1bl9yZWcsIDApOwo+PiDCoCDCoMKg wqDCoMKgIC8qIFNldHVwIHRyaWdnZXIgbGV2ZWwgZm9yIFRYL1JYIEZJRk9zICovCj4+IMKgwqDC oMKgwqAgc2NpZl93cml0ZXcodWFydCwgU0NJRl9TQ0ZDUiwgU0NGQ1JfUlRSRzExIHwgU0NGQ1Jf VFRSRzExKTsKPj4gQEAgLTExMSw2ICsxNTAsNyBAQCBzdGF0aWMgdm9pZCBfX2luaXQgc2NpZl91 YXJ0X2luaXRfcHJlaXJxKHN0cnVjdCAKPj4gc2VyaWFsX3BvcnQgKnBvcnQpCj4+IMKgIHN0YXRp YyB2b2lkIF9faW5pdCBzY2lmX3VhcnRfaW5pdF9wb3N0aXJxKHN0cnVjdCBzZXJpYWxfcG9ydCAq cG9ydCkKPj4gwqAgewo+PiDCoMKgwqDCoMKgIHN0cnVjdCBzY2lmX3VhcnQgKnVhcnQgPSBwb3J0 LT51YXJ0Owo+PiArwqDCoMKgIGNvbnN0IHN0cnVjdCBwb3J0X3BhcmFtcyAqcGFyYW1zID0gdWFy dC0+cGFyYW1zOwo+PiDCoMKgwqDCoMKgIGludCByYzsKPj4gwqAgwqDCoMKgwqDCoCB1YXJ0LT5p cnFhY3Rpb24uaGFuZGxlciA9IHNjaWZfdWFydF9pbnRlcnJ1cHQ7Cj4+IEBAIC0xMjIsMTQgKzE2 MiwxNyBAQCBzdGF0aWMgdm9pZCBfX2luaXQgCj4+IHNjaWZfdWFydF9pbml0X3Bvc3RpcnEoc3Ry dWN0IHNlcmlhbF9wb3J0ICpwb3J0KQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIHVhcnQtPmlycSk7Cj4+IMKgIMKgwqDCoMKgwqAgLyogQ2xlYXIgYWxsIGVycm9ycyAqLwo+ PiAtwqDCoMKgIGlmICggc2NpZl9yZWFkdyh1YXJ0LCBTQ0lGX1NDRlNSKSAmIFNDSUZfRVJST1JT ICkKPj4gLcKgwqDCoMKgwqDCoMKgIHNjaWZfd3JpdGV3KHVhcnQsIFNDSUZfU0NGU1IsIH5TQ0lG X0VSUk9SUyk7Cj4+IC3CoMKgwqAgaWYgKCBzY2lmX3JlYWR3KHVhcnQsIFNDSUZfU0NMU1IpICYg U0NMU1JfT1JFUiApCj4+IC3CoMKgwqDCoMKgwqDCoCBzY2lmX3dyaXRldyh1YXJ0LCBTQ0lGX1ND TFNSLCAwKTsKPj4gK8KgwqDCoCBpZiAoIHNjaWZfcmVhZHcodWFydCwgcGFyYW1zLT5zdGF0dXNf cmVnKSAmIHBhcmFtcy0+ZXJyb3JfbWFzayApCj4+ICvCoMKgwqDCoMKgwqDCoCBzY2lmX3dyaXRl dyh1YXJ0LCBwYXJhbXMtPnN0YXR1c19yZWcsIH5wYXJhbXMtPmVycm9yX21hc2spOwo+PiArwqDC oMKgIGlmICggcGFyYW1zLT5vdmVycnVuX3JlZyAhPSBwYXJhbXMtPnN0YXR1c19yZWcgKQo+Cj4g U2FtZSBxdWVzdGlvbiBoZXJlLgo+Cj4gWy4uLl0KClBsZWFzZSBzZWUgdGhlIGFuc3dlciBhYm92 ZS4KCgo+Cj4+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGR0X2RldmljZV9tYXRjaCBzY2lmX3VhcnRf ZHRfbWF0Y2hbXSBfX2luaXRjb25zdCA9Cj4+ICt7Cj4+ICvCoMKgwqAgeyAuY29tcGF0aWJsZSA9 ICJyZW5lc2FzLHNjaWYiLMKgIC5kYXRhID0gKHZvaWQgKilTQ0lGX1BPUlQgfSwKPj4gK8KgwqDC oCB7IC8qIHNlbnRpbmVsICovIH0sCj4+ICt9Owo+PiArCj4+IMKgIHN0YXRpYyBpbnQgX19pbml0 IHNjaWZfdWFydF9pbml0KHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqZGV2LAo+PiDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCBjb25zdCB2b2lkICpkYXRhKQo+PiDCoCB7Cj4+ICvCoMKgwqAgY29uc3Qgc3RydWN0IGR0X2Rl dmljZV9tYXRjaCAqbWF0Y2g7Cj4+IMKgwqDCoMKgwqAgY29uc3QgY2hhciAqY29uZmlnID0gZGF0 YTsKPj4gwqDCoMKgwqDCoCBzdHJ1Y3Qgc2NpZl91YXJ0ICp1YXJ0Owo+PiDCoMKgwqDCoMKgIGlu dCByZXM7Cj4+IEBAIC0yNjUsMTAgKzMxOSwxMyBAQCBzdGF0aWMgaW50IF9faW5pdCBzY2lmX3Vh cnRfaW5pdChzdHJ1Y3QgCj4+IGR0X2RldmljZV9ub2RlICpkZXYsCj4+IMKgwqDCoMKgwqDCoMKg wqDCoCByZXR1cm4gLUVOT01FTTsKPj4gwqDCoMKgwqDCoCB9Cj4+IMKgICvCoMKgwqAgbWF0Y2gg PSBkdF9tYXRjaF9ub2RlKHNjaWZfdWFydF9kdF9tYXRjaCwgZGV2KTsKPgo+IFRlY2huaWNhbGx5 IGR0X21hdGNoX25vZGUgbWF5IHJldHVybiBOVUxMIGhlcmUuIFRoaXMgc2hvdWxkIG5ldmVyIGJl IAo+IHRoZSBjYXNlIGFzIHlvdSBrbm93IGl0IHdpbGwgYWx3YXlzIG1hdGNoLgo+Cj4gU28gSSB3 b3VsZCBhZGQgYW4gQVNTRVJUKG1hdGNoKSBoZXJlLgoKT0sKCgo+Cj4gQ2hlZXJzLAo+Ci0tIApS ZWdhcmRzLAoKT2xla3NhbmRyIFR5c2hjaGVua28KCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBs aXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4v bGlzdGluZm8veGVuLWRldmVs