Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC8232D6E64 for ; Thu, 6 Nov 2025 09:59:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762423170; cv=none; b=DqhOyz80dfWwYjjkS1BLaiirCZiSnlhHtMMx82X56AhegEVNgAdlLPPMtEXZgvgPp3LnD8gepiVJS1zZ8OF3m27BpJpozFMUi6urIjFT1mIyxFSKIgG1ySYwOlgD8VB6JRChN5+i06eJIZboKCTcmfxp9E9DjJqyUMJ3Y0ga6LE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762423170; c=relaxed/simple; bh=M7KoYUSvmP9vmPAfKlpFPWflu3zyoOr//XRy2DLsslI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AARbxrohhl9aydB1JNq8bOA5aFLO55PYU4/3AyHerGuW3hlYJ8Tuli6qCpfaSMXNG7KId91DwBBPd5WRaerbaj9XVFUXNBXkWmWM+8CNlg8asbgOcS9A0+HHSA57U7uXSQo9Y2YI6rSl5AqPrrQJnPimHnLDyEcfkeCxx9lZBLI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=SWxt0HHg; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="SWxt0HHg" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id E62944E41562; Thu, 6 Nov 2025 09:59:26 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id B5AAF6068C; Thu, 6 Nov 2025 09:59:26 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C06C91185083F; Thu, 6 Nov 2025 10:59:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1762423165; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=HRB6WKG1GPAIoa2JCrM8EfDN42soLkOAEM4gs/5hgPg=; b=SWxt0HHgJMXX3psveFa7aHtJ33bkAHk1fJrd2IyRd6ucLNrA1xrw/5+qj2rBbGql9yscu2 bEEIDl1P0oMdo9gAukmXZbwJ/2t15M++E8AndRjF5wRO6UJ/Ouz2SPbIMdEmuS0fSQJmHj 7Z4TIoMBzylDMHzN2la+EoU4DY71e4EvZ4NubYmUKKmwVhzZP14iA8JBKwDQXMfz1U0NvI IsBzmSvSFHWAstX52MN/Sk8Wb113kahpVW4Lag/RmOIDAW8HZsu5XFp/SwtglPotDidOhM SUAIt52Dmxh4qDYDJPTlwSxkp01Aqai/D5dmJ/Lch5sUI8rj0CWcNLp0uW8Tkg== Message-ID: <1c1a272c-3e5b-4e79-9b06-5dfb830293eb@bootlin.com> Date: Thu, 6 Nov 2025 10:59:23 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 02/11] net: stmmac: ingenic: simplify jz4775 mac_set_mode() To: "Russell King (Oracle)" , Andrew Lunn , Heiner Kallweit Cc: Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni References: From: Maxime Chevallier Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 06/11/2025 09:57, Russell King (Oracle) wrote: > All paths configure the transmit clock as an input. Move this out of > the switch() statement to simplify the code. > > Signed-off-by: Russell King (Oracle) Reviewed-by: Maxime Chevallier Maxime > --- > .../net/ethernet/stmicro/stmmac/dwmac-ingenic.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c > index 8d0627055799..c6c82f277f62 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c > @@ -78,20 +78,17 @@ static int jz4775_mac_set_mode(struct plat_stmmacenet_data *plat_dat) > > switch (plat_dat->phy_interface) { > case PHY_INTERFACE_MODE_MII: > - val = FIELD_PREP(MACPHYC_TXCLK_SEL_MASK, MACPHYC_TXCLK_SEL_INPUT) | > - FIELD_PREP(MACPHYC_PHY_INFT_MASK, MACPHYC_PHY_INFT_MII); > + val = FIELD_PREP(MACPHYC_PHY_INFT_MASK, MACPHYC_PHY_INFT_MII); > dev_dbg(mac->dev, "MAC PHY Control Register: PHY_INTERFACE_MODE_MII\n"); > break; > > case PHY_INTERFACE_MODE_GMII: > - val = FIELD_PREP(MACPHYC_TXCLK_SEL_MASK, MACPHYC_TXCLK_SEL_INPUT) | > - FIELD_PREP(MACPHYC_PHY_INFT_MASK, MACPHYC_PHY_INFT_GMII); > + val = FIELD_PREP(MACPHYC_PHY_INFT_MASK, MACPHYC_PHY_INFT_GMII); > dev_dbg(mac->dev, "MAC PHY Control Register: PHY_INTERFACE_MODE_GMII\n"); > break; > > case PHY_INTERFACE_MODE_RMII: > - val = FIELD_PREP(MACPHYC_TXCLK_SEL_MASK, MACPHYC_TXCLK_SEL_INPUT) | > - FIELD_PREP(MACPHYC_PHY_INFT_MASK, MACPHYC_PHY_INFT_RMII); > + val = FIELD_PREP(MACPHYC_PHY_INFT_MASK, MACPHYC_PHY_INFT_RMII); > dev_dbg(mac->dev, "MAC PHY Control Register: PHY_INTERFACE_MODE_RMII\n"); > break; > > @@ -99,8 +96,7 @@ static int jz4775_mac_set_mode(struct plat_stmmacenet_data *plat_dat) > case PHY_INTERFACE_MODE_RGMII_ID: > case PHY_INTERFACE_MODE_RGMII_TXID: > case PHY_INTERFACE_MODE_RGMII_RXID: > - val = FIELD_PREP(MACPHYC_TXCLK_SEL_MASK, MACPHYC_TXCLK_SEL_INPUT) | > - FIELD_PREP(MACPHYC_PHY_INFT_MASK, MACPHYC_PHY_INFT_RGMII); > + val = FIELD_PREP(MACPHYC_PHY_INFT_MASK, MACPHYC_PHY_INFT_RGMII); > dev_dbg(mac->dev, "MAC PHY Control Register: PHY_INTERFACE_MODE_RGMII\n"); > break; > > @@ -110,6 +106,8 @@ static int jz4775_mac_set_mode(struct plat_stmmacenet_data *plat_dat) > return -EINVAL; > } > > + val |= FIELD_PREP(MACPHYC_TXCLK_SEL_MASK, MACPHYC_TXCLK_SEL_INPUT); > + > /* Update MAC PHY control register */ > return regmap_update_bits(mac->regmap, 0, mac->soc_info->mask, val); > }