From: "flichtenheld (Code Review)" Date: Fri, 1 Dec 2023 12:28:54 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <1c3d2844a3cf62cf8012625add3fcd7fcc464eb8-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="MH+0scd4+2s="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Check PRF availability on initialisation and add --force-tls-key-mate... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --MH+0scd4+2s= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/460?usp=3Demail ) Change subject: Check PRF availability on initialisation and add --force-tl= s-key-material-export ...................................................................... Patch Set 4: Code-Review-1 (1 comment) File src/openvpn/crypto.c: http://gerrit.openvpn.net/c/openvpn/+/460/comment/8d18aa2f_604e3d4b : PS3, Line 1797: * limits our compatibility to other 2.6.x+ OperVPN pee= rs. Do a simple > limits in the sense that we are limited to only 2.6.0+ peers. [=E2=80=A6] I think my problem is "limits our compatibility to". I find it difficult to= parse that correctly. May I suggest to drop that? "This only allows us to = establish connections with peers that support keying material export (e.g. = OpenVPN 2.6.0+)." -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/460?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I04f8c7c413e7cb62c726262feee6ca89c7e86c70 Gerrit-Change-Number: 460 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Fri, 01 Dec 2023 12:28:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: plaisthos Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment --MH+0scd4+2s= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

Patch set 4:Code-Review -1=

Vi= ew Change

1 comment:

  • File src/openvpn/crypto.c:

  • Patch Set #3, Line 1797:= * limits our comp= atibility to other 2.6.x+ OperVPN peers. Do a simple

    = limits in the sense that we are limited to only 2.6.0+ peers. [=E2=80=A6]

    I= think my problem is "limits our compatibility to". I find it dif= ficult to parse that correctly. May I suggest to drop that? "This only= allows us to establish connections with peers that support keying material= export (e.g. OpenVPN 2.6.0+)."

To view, vis= it change= 460. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I04f8c7c413e7cb62c726262feee= 6ca89c7e86c70
Gerrit-Change-Number: 460
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Comment-Date: Fri, 01 Dec 2023 12:28:54= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos <arne-openvp= n@...1227...>
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
Gerrit-MessageType: comment
--MH+0scd4+2s=--