From: "ssbssa (Code Review)" Date: Mon, 3 Jun 2024 14:35:28 +0000 In-Reply-To: References: Reply-To: ssbssa@...360..., arne-openvpn@...1227..., selva.nair@...277..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <1c43eb315e089099b7b5341b27633b1fb177ada4-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="SMApW+gvy6A="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Implement Windows CA template match for Crypto-API selector List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: selvanair , plaisthos , flichtenheld , openvpn-devel --SMApW+gvy6A= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos, selvanair. ssbssa has posted comments on this change. ( http://gerrit.openvpn.net/c/op= envpn/+/621?usp=3Demail ) Change subject: Implement Windows CA template match for Crypto-API selector ...................................................................... Patch Set 2: (6 comments) Patchset: PS2: The new patch should resolve all comments. File doc/man-sections/windows-options.rst: http://gerrit.openvpn.net/c/openvpn/+/621/comment/dea7be4c_cb1afe99 : PS1, Line 62: cryptoapicert "TMPL:1.3.6.1.4..." > Add an example where the template name is used instead of OID? Done File src/openvpn/cryptoapi.c: http://gerrit.openvpn.net/c/openvpn/+/621/comment/63f95189_515a1777 : PS1, Line 217: } > I think I said this in response to the original in 2021 as well: why sepa= rate into two calls like th [=E2=80=A6] Done http://gerrit.openvpn.net/c/openvpn/+/621/comment/404e038e_7d02372b : PS1, Line 220: if (!info && fallback && groupid) > I see the only place this is called is with fallback=3Dtrue, so we do not= need that argument and can a [=E2=80=A6] Done http://gerrit.openvpn.net/c/openvpn/+/621/comment/f5b1a275_d56ff8fa : PS1, Line 277: * TMPL: