From: "ssbssa (Code Review)"
Date: Mon, 3 Jun 2024 14:35:28 +0000
In-Reply-To:
References:
Reply-To: ssbssa@...360..., arne-openvpn@...1227..., selva.nair@...277...,
openvpn-devel@lists.sourceforge.net, frank@...2641...
Message-ID: <1c43eb315e089099b7b5341b27633b1fb177ada4-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="SMApW+gvy6A="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: Implement Windows CA
template match for Crypto-API selector
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: selvanair , plaisthos , flichtenheld , openvpn-devel
--SMApW+gvy6A=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos, selvanair.
ssbssa has posted comments on this change. ( http://gerrit.openvpn.net/c/op=
envpn/+/621?usp=3Demail )
Change subject: Implement Windows CA template match for Crypto-API selector
......................................................................
Patch Set 2:
(6 comments)
Patchset:
PS2:
The new patch should resolve all comments.
File doc/man-sections/windows-options.rst:
http://gerrit.openvpn.net/c/openvpn/+/621/comment/dea7be4c_cb1afe99 :
PS1, Line 62: cryptoapicert "TMPL:1.3.6.1.4..."
> Add an example where the template name is used instead of OID?
Done
File src/openvpn/cryptoapi.c:
http://gerrit.openvpn.net/c/openvpn/+/621/comment/63f95189_515a1777 :
PS1, Line 217: }
> I think I said this in response to the original in 2021 as well: why sepa=
rate into two calls like th [=E2=80=A6]
Done
http://gerrit.openvpn.net/c/openvpn/+/621/comment/404e038e_7d02372b :
PS1, Line 220: if (!info && fallback && groupid)
> I see the only place this is called is with fallback=3Dtrue, so we do not=
need that argument and can a [=E2=80=A6]
Done
http://gerrit.openvpn.net/c/openvpn/+/621/comment/f5b1a275_d56ff8fa :
PS1, Line 277: * TMPL:
> template name or OID ?
Done
http://gerrit.openvpn.net/c/openvpn/+/621/comment/79d659be_2fe54731 :
PS1, Line 314: find_type =3D CERT_FIND_ANY;
> Shouldn't we use a more restrictive search with, say, CERT_FIND_HAS_PRIVA=
TE_KEY? If there are multip [=E2=80=A6]
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/621?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia2c3e4c5c83ecccce1618c43b489dbe811de5351
Gerrit-Change-Number: 621
Gerrit-PatchSet: 2
Gerrit-Owner: ssbssa
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-CC: selvanair
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Attention: selvanair
Gerrit-Comment-Date: Mon, 03 Jun 2024 14:35:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: selvanair
Gerrit-MessageType: comment
--SMApW+gvy6A=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos, selvanai=
r.
View C=
hange
6 comments:
Done
=
ul>File src/openvpn/cryptoapi.=
c:
Patch Set #1, Li=
ne 217: }
I think I said this in response to the original in 2021 as wel=
l: why separate into two calls like th [=E2=80=A6]
Done
=
Patch Set #1, Line 220: if (!info && fallback && groupid)
I see the only place this is called is with fallback=3Dtrue, so we do not=
need that argument and can a [=E2=80=A6]
Done
Patch Set #=
1, Line 277: * TMP=
L:<template name>
template name or OID ?Done=
p>
Patch Set #1, Line 314: find_type =3D CERT_FIND_ANY;
Shouldn't we use a more restrictive search with, say, CERT_FIND_HAS_PR=
IVATE_KEY? If there are multip [=E2=80=A6]
Done
T=
o view, visit change 621. To unsubscribe, or for help writing mail filters, visi=
t settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia2c3e4c5c83ecccce1618c43b48=
9dbe811de5351
Gerrit-Change-Number: 621
Gerrit-PatchSet: 2
Gerrit-Owner: ssbssa <ssbssa@...360...> =
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-CC: selvanair <selva.nair@...277...&=
gt;
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Attention: selvanair <selva.nair@...493...=
277...>
Gerrit-Comment-Date: Mon, 03 Jun 2024 14:35:28=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: selvanair <selva.nair@=
...277...>
Gerrit-MessageType: comment
--SMApW+gvy6A=--