Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAF3EC433E1 for ; Thu, 20 Aug 2020 21:33:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8895C21734 for ; Thu, 20 Aug 2020 21:33:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y8Ga9VBr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8895C21734 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8sBy-0000v0-Pc for qemu-devel@archiver.kernel.org; Thu, 20 Aug 2020 17:33:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46358) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8sB2-0008Vf-6b for qemu-devel@nongnu.org; Thu, 20 Aug 2020 17:32:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:39003) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k8sB0-0007LG-DW for qemu-devel@nongnu.org; Thu, 20 Aug 2020 17:32:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597959169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pYQb59aFDYnkXFsD2gIgUo678y4u0i+N5sJ+0SR/n5o=; b=Y8Ga9VBr7ajH7jtJJQDiSXV9rsG7pgu7uXBrXOJJaXIhVrqXhflhgyDOXVOpRSiI7lARxw z5z7uC6ASszAcKmBYeFlV5WoLYoeAOJ72lEYkevixg8P+BqaSicCc7H8LD4+YFYj2w2Yl4 nWLL0M65pAcAks2S5xjt9oXmLMv2lqQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-305-Tv_c5EYUN4an7-I833a0bA-1; Thu, 20 Aug 2020 17:32:47 -0400 X-MC-Unique: Tv_c5EYUN4an7-I833a0bA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B689710060C2; Thu, 20 Aug 2020 21:32:09 +0000 (UTC) Received: from [10.3.114.63] (ovpn-114-63.phx2.redhat.com [10.3.114.63]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 559B95E1DF; Thu, 20 Aug 2020 21:32:09 +0000 (UTC) Subject: Re: [PATCH] qemu-iotests: Fix FilePaths cleanup From: Eric Blake To: Nir Soffer , qemu-devel@nongnu.org References: <20200820211905.223523-1-nsoffer@redhat.com> Organization: Red Hat, Inc. Message-ID: <1c5963e6-e85c-a46e-9133-fb8a072434dd@redhat.com> Date: Thu, 20 Aug 2020 16:32:08 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/20 17:32:49 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/20/20 4:29 PM, Eric Blake wrote: > On 8/20/20 4:19 PM, Nir Soffer wrote: >> If os.remove() fails to remove one of the paths, for example if the file >> was removed by the test, the cleanup loop would exit silently, without >> removing the rest of the files. >> >> Signed-off-by: Nir Soffer >> --- >>   dtc                           | 2 +- >>   tests/qemu-iotests/iotests.py | 8 ++++---- >>   2 files changed, 5 insertions(+), 5 deletions(-) > > Reviewed-by: Eric Blake By the way, what test did you hit this on? If possible, I'd like to add a Fixes: tag pointing to a commit that includes the problem. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org