From: Waiman Long Subject: Re: [PATCH v3 2/5] mm/memcg: Introduce obj_cgroup_uncharge_mod_state() Date: Thu, 15 Apr 2021 12:35:45 -0400 Message-ID: <1c85e8f6-e8b9-33e1-e29b-81fbadff959f@redhat.com> References: <20210414012027.5352-1-longman@redhat.com> <20210414012027.5352-3-longman@redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618504549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s47wUvhDxo7f8LaX+UuV/f8OqzaAqCVXK0vtBt6gLnc=; b=c/OSYHYhaOiH4fd4gO9bUOMnYHa0BctwWZ9rTgb6cT0+9A/err5J76HUQrZ39/XvxRG/5m 2aUUgFRnkBbUYr3+nxzxD9N+ycRbh1EUf7MeFl9EjcD7Zt1yA7fhRt2voHcQky6i9WIGPd qSSFdCYNDXkXSMTm9W2MYWxMarDXQuE= In-Reply-To: Content-Language: en-US List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Johannes Weiner Cc: Michal Hocko , Vladimir Davydov , Andrew Morton , Tejun Heo , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Shakeel Butt , Muchun Song , Alex Shi , Chris Down , Yafang Shao , Wei Yang , Masayoshi Mizuma , Xing Zhengjun On 4/15/21 12:30 PM, Johannes Weiner wrote: > On Tue, Apr 13, 2021 at 09:20:24PM -0400, Waiman Long wrote: >> In memcg_slab_free_hook()/pcpu_memcg_free_hook(), obj_cgroup_uncharge() >> is followed by mod_objcg_state()/mod_memcg_state(). Each of these >> function call goes through a separate irq_save/irq_restore cycle. That >> is inefficient. Introduce a new function obj_cgroup_uncharge_mod_state() >> that combines them with a single irq_save/irq_restore cycle. >> >> @@ -3292,6 +3296,25 @@ void obj_cgroup_uncharge(struct obj_cgroup *objcg, size_t size) >> refill_obj_stock(objcg, size); >> } >> >> +void obj_cgroup_uncharge_mod_state(struct obj_cgroup *objcg, size_t size, >> + struct pglist_data *pgdat, int idx) > The optimization makes sense. > > But please don't combine independent operations like this into a > single function. It makes for an unclear parameter list, it's a pain > in the behind to change the constituent operations later on, and it > has a habit of attracting more random bools over time. E.g. what if > the caller already has irqs disabled? What if it KNOWS that irqs are > enabled and it could use local_irq_disable() instead of save? > > Just provide an __obj_cgroup_uncharge() that assumes irqs are > disabled, combine with the existing __mod_memcg_lruvec_state(), and > bubble the irq handling up to those callsites which know better. > That will also work. However, the reason I did that was because of patch 5 in the series. I could put the get_obj_stock() and put_obj_stock() code in slab.h and allowed them to be used directly in various places, but hiding in one function is easier. Anyway, I can change the patch if you think that is the right way. Cheers, Longman