Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5EB627708 for ; Thu, 10 Aug 2023 08:32:20 +0000 (UTC) Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B38B5E56; Thu, 10 Aug 2023 01:32:18 -0700 (PDT) Received: from lhrpeml100006.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4RM0S93F6Pz6J7Xv; Thu, 10 Aug 2023 16:28:25 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (7.191.163.240) by lhrpeml100006.china.huawei.com (7.191.160.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 09:32:16 +0100 Received: from lhrpeml500005.china.huawei.com ([7.191.163.240]) by lhrpeml500005.china.huawei.com ([7.191.163.240]) with mapi id 15.01.2507.027; Thu, 10 Aug 2023 09:32:16 +0100 From: Shameerali Kolothum Thodi To: Brett Creeley , "kvm@vger.kernel.org" , "netdev@vger.kernel.org" , "alex.williamson@redhat.com" , "jgg@nvidia.com" , "yishaih@nvidia.com" , "kevin.tian@intel.com" CC: "horms@kernel.org" , "shannon.nelson@amd.com" Subject: RE: [PATCH v14 vfio 0/8] pds-vfio-pci driver Thread-Topic: [PATCH v14 vfio 0/8] pds-vfio-pci driver Thread-Index: AQHZyXHv3bTrp0qnokyw6FJ+IoQZlq/jNQAg Date: Thu, 10 Aug 2023 08:32:15 +0000 Message-ID: <1d01d5f4063444ecbf7a258289d0e1d6@huawei.com> References: <20230807205755.29579-1-brett.creeley@amd.com> In-Reply-To: <20230807205755.29579-1-brett.creeley@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.227.178] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net > -----Original Message----- > From: Brett Creeley [mailto:brett.creeley@amd.com] > Sent: 07 August 2023 21:58 > To: kvm@vger.kernel.org; netdev@vger.kernel.org; > alex.williamson@redhat.com; jgg@nvidia.com; yishaih@nvidia.com; > Shameerali Kolothum Thodi ; > kevin.tian@intel.com > Cc: horms@kernel.org; brett.creeley@amd.com; shannon.nelson@amd.com > Subject: [PATCH v14 vfio 0/8] pds-vfio-pci driver >=20 > This is a patchset for a new vendor specific VFIO driver > (pds-vfio-pci) for use with the AMD/Pensando Distributed Services > Card (DSC). This driver makes use of the pds_core driver. >=20 > This driver will use the pds_core device's adminq as the VFIO > control path to the DSC. In order to make adminq calls, the VFIO > instance makes use of functions exported by the pds_core driver. >=20 > In order to receive events from pds_core, the pds-vfio-pci driver > registers to a private notifier. This is needed for various events > that come from the device. >=20 > An ASCII diagram of a VFIO instance looks something like this and can > be used with the VFIO subsystem to provide the VF device VFIO and live > migration support. >=20 > .------. .-----------------------. > | QEMU |--| VM .-------------. | > '......' | | Eth VF | | > | | .-------------. | > | | | SR-IOV VF | > | > | | '-------------' | > | '------------||---------' > .--------------. || > |/dev/| || > '--------------' || > Host Userspace | || > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D || > Host Kernel | || > .--------. || > |vfio-pci| || > '--------' || > .------------------. || || > | | exported API |<----+ || || > | '--------------| | || || > | | .--------------. || > | pds_core |--->| pds-vfio-pci | || > '------------------' | '--------------' || > || | || || > 09:00.0 notifier 09:00.1 || > =3D=3D PCI =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D||=3D=3D=3D=3D=3D > || || || > .----------. .----------. || > ,-----| PF |----------| VF |-------------------, > | '----------' |'----------' VF | > | DSC | data/control | > | | path | > ----------------------------------------------------------- >=20 > The pds-vfio-pci driver is targeted to reside in drivers/vfio/pci/pds. > It makes use of and introduces new files in the common include/linux/pds > include directory. Looks fine to me.=20 For series, Reviewed-by: Shameer Kolothum Thanks, Shameer