Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E18D8C352AA for ; Mon, 7 Oct 2019 11:46:13 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B639D206C2 for ; Mon, 7 Oct 2019 11:46:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B639D206C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iHRSa-0006Dl-3c; Mon, 07 Oct 2019 11:45:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iHRSZ-0006Dg-7q for xen-devel@lists.xenproject.org; Mon, 07 Oct 2019 11:45:51 +0000 X-Inumbo-ID: 01783980-e8f8-11e9-80e3-bc764e2007e4 Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 01783980-e8f8-11e9-80e3-bc764e2007e4; Mon, 07 Oct 2019 11:45:49 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 2CC35AE3F; Mon, 7 Oct 2019 11:45:48 +0000 (UTC) To: Roger Pau Monne References: <20190930133238.49868-1-roger.pau@citrix.com> <20190930133238.49868-8-roger.pau@citrix.com> From: Jan Beulich Message-ID: <1d3d91e2-40c8-235b-b3ed-e7feefa7dc43@suse.com> Date: Mon, 7 Oct 2019 13:45:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20190930133238.49868-8-roger.pau@citrix.com> Content-Language: en-US Subject: Re: [Xen-devel] [PATCH v3 07/10] ioreq: allow decoding accesses to MMCFG regions X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Paul Durrant , Wei Liu , Andrew Cooper Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gMzAuMDkuMjAxOSAxNTozMiwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOgo+IC0tLSBhL3hlbi9h cmNoL3g4Ni9odm0vaW8uYwo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9odm0vaW8uYwo+IEBAIC0yNzks NiArMjc5LDE4IEBAIHVuc2lnbmVkIGludCBodm1fcGNpX2RlY29kZV9hZGRyKHVuc2lnbmVkIGlu dCBjZjgsIHVuc2lnbmVkIGludCBhZGRyLAo+ICAgICAgcmV0dXJuIENGOF9BRERSX0xPKGNmOCkg fCAoYWRkciAmIDMpOwo+ICB9Cj4gIAo+ICt1bnNpZ25lZCBpbnQgaHZtX21tY2ZnX2RlY29kZV9h ZGRyKGNvbnN0IHN0cnVjdCBodm1fbW1jZmcgKm1tY2ZnLAo+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHBhZGRyX3QgYWRkciwgcGNpX3NiZGZfdCAqc2JkZikKPiArewo+ICsg ICAgYWRkciAtPSBtbWNmZy0+YWRkcjsKCkFzIHRoZSBmdW5jdGlvbiBpc24ndCBldmVuIHN0YXRp Yywgd291bGRuJ3QgaXQgYmUgaGVscGZ1bCB0byBhdCBsZWFzdAphc3NlcnQgdGhhdCBhZGRyID49 IG1tY2ZnLT5hZGRyIGFoZWFkIG9mIHRoaXMsIGFuZCBhZGRyIDwgbW1jZmctPnNpemUKYWZ0ZXJ3 YXJkcz8KCj4gQEAgLTU3NCw2ICs1NTAsMTcgQEAgdm9pZCBkZXN0cm95X3ZwY2lfbW1jZmcoc3Ry dWN0IGRvbWFpbiAqZCkKPiAgICAgIHdyaXRlX3VubG9jaygmZC0+YXJjaC5odm0ubW1jZmdfbG9j ayk7Cj4gIH0KPiAgCj4gK2NvbnN0IHN0cnVjdCBodm1fbW1jZmcgKmh2bV9tbWNmZ19maW5kKGNv bnN0IHN0cnVjdCBkb21haW4gKmQsIHBhZGRyX3QgYWRkcikKPiArewo+ICsgICAgY29uc3Qgc3Ry dWN0IGh2bV9tbWNmZyAqbW1jZmc7Cj4gKwo+ICsgICAgbGlzdF9mb3JfZWFjaF9lbnRyeSAoIG1t Y2ZnLCAmZC0+YXJjaC5odm0ubW1jZmdfcmVnaW9ucywgbmV4dCApCj4gKyAgICAgICAgaWYgKCBh ZGRyID49IG1tY2ZnLT5hZGRyICYmIGFkZHIgPCBtbWNmZy0+YWRkciArIG1tY2ZnLT5zaXplICkK CkFzIGEgbWlub3IgcmVtYXJrLCB0aGlzIGNvdWxkIGJlIGNvZGVkIHdpdGhvdXQgZXZlbiBhIHRo ZW9yZXRpY2FsIHJpc2sKb2Ygb3ZlcmZsb3cgYXMKCiAgICAgICAgaWYgKCBhZGRyID49IG1tY2Zn LT5hZGRyICYmIGFkZHIgLSBtbWNmZy0+YWRkciA8IG1tY2ZnLT5zaXplICkKCj4gLS0tIGEveGVu L2FyY2gveDg2L2h2bS9pb3JlcS5jCj4gKysrIGIveGVuL2FyY2gveDg2L2h2bS9pb3JlcS5jCj4g QEAgLTEzMjYsMjcgKzEzMjYsMzQgQEAgaW9zZXJ2aWRfdCBodm1fc2VsZWN0X2lvcmVxX3NlcnZl cihzdHJ1Y3QgZG9tYWluICpkLCBpb3JlcV90ICpwKQo+ICAgICAgdWludDhfdCB0eXBlOwo+ICAg ICAgdWludDY0X3QgYWRkcjsKPiAgICAgIHVuc2lnbmVkIGludCBpZDsKPiArICAgIGNvbnN0IHN0 cnVjdCBodm1fbW1jZmcgKm1tY2ZnOwo+ICAKPiAgICAgIGlmICggcC0+dHlwZSAhPSBJT1JFUV9U WVBFX0NPUFkgJiYgcC0+dHlwZSAhPSBJT1JFUV9UWVBFX1BJTyApCj4gICAgICAgICAgcmV0dXJu IFhFTl9JTlZBTElEX0lPU0VSVklEOwo+ICAKPiAgICAgIGNmOCA9IGQtPmFyY2guaHZtLnBjaV9j Zjg7Cj4gIAo+IC0gICAgaWYgKCBwLT50eXBlID09IElPUkVRX1RZUEVfUElPICYmCj4gLSAgICAg ICAgIChwLT5hZGRyICYgfjMpID09IDB4Y2ZjICYmCj4gLSAgICAgICAgIENGOF9FTkFCTEVEKGNm OCkgKQo+ICsgICAgcmVhZF9sb2NrKCZkLT5hcmNoLmh2bS5tbWNmZ19sb2NrKTsKPiArICAgIGlm ICggKHAtPnR5cGUgPT0gSU9SRVFfVFlQRV9QSU8gJiYKPiArICAgICAgICAgIChwLT5hZGRyICYg fjMpID09IDB4Y2ZjICYmCj4gKyAgICAgICAgICBDRjhfRU5BQkxFRChjZjgpKSB8fAo+ICsgICAg ICAgICAocC0+dHlwZSA9PSBJT1JFUV9UWVBFX0NPUFkgJiYKPiArICAgICAgICAgIChtbWNmZyA9 IGh2bV9tbWNmZ19maW5kKGQsIHAtPmFkZHIpKSAhPSBOVUxMKSApCj4gICAgICB7Cj4gICAgICAg ICAgdWludDMyX3QgeDg2X2ZhbTsKPiAgICAgICAgICBwY2lfc2JkZl90IHNiZGY7Cj4gICAgICAg ICAgdW5zaWduZWQgaW50IHJlZzsKPiAgCj4gLSAgICAgICAgcmVnID0gaHZtX3BjaV9kZWNvZGVf YWRkcihjZjgsIHAtPmFkZHIsICZzYmRmKTsKPiArICAgICAgICByZWcgPSBwLT50eXBlID09IElP UkVRX1RZUEVfUElPID8gaHZtX3BjaV9kZWNvZGVfYWRkcihjZjgsIHAtPmFkZHIsCj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg JnNiZGYpCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6IGh2bV9t bWNmZ19kZWNvZGVfYWRkcihtbWNmZywgcC0+YWRkciwKPiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZzYmRmKTsKCkknbSBh ZnJhaWQgb2xkIGdjYyB3aWxsIGNvbnNpZGVyIHRoaXMgdXNlIG9mIG1tY2ZnICJwb3RlbnRpYWxs eQp1bmluaXRpYWxpemVkIi4gSS5lLiBJIHRoaW5rIHRoZSB2YXJpYWJsZSB3YW50cyB0byBnYWlu IGEgTlVMTAppbml0aWFsaXplciwgYXQgd2hpY2ggcG9pbnQgeW91IGNhbiBzbGlnaHRseSBzaG9y dGVuIHRoZSBhYm92ZQp0bwoKICAgICAgICByZWcgPSBtbWNmZyA/IGh2bV9tbWNmZ19kZWNvZGVf YWRkcihtbWNmZywgcC0+YWRkciwgJnNiZGYpCiAgICAgICAgICAgICAgICAgICAgOiBodm1fcGNp X2RlY29kZV9hZGRyKGNmOCwgcC0+YWRkciwgJnNiZGYpOwoKCmFsc28gZWxpbWluYXRpbmcgYSBw b2ludGVyIGRlcmVmIChpLmUuIGxpa2VseSBwcm9kdWNpbmcgbWluaW1hbGx5Cm1vcmUgZWZmaWNp ZW50IGNvZGUpLgoKPiAgICAgICAgICAvKiBQQ0kgY29uZmlnIGRhdGEgY3ljbGUgKi8KPiAgICAg ICAgICB0eXBlID0gWEVOX0RNT1BfSU9fUkFOR0VfUENJOwo+ICAgICAgICAgIGFkZHIgPSAoKHVp bnQ2NF90KXNiZGYuc2JkZiA8PCAzMikgfCByZWc7Cj4gICAgICAgICAgLyogQU1EIGV4dGVuZGVk IGNvbmZpZ3VyYXRpb24gc3BhY2UgYWNjZXNzPyAqLwo+IC0gICAgICAgIGlmICggQ0Y4X0FERFJf SEkoY2Y4KSAmJgo+ICsgICAgICAgIGlmICggcC0+dHlwZSA9PSBJT1JFUV9UWVBFX1BJTyAmJiBD RjhfQUREUl9ISShjZjgpICYmCgpXb3VsZCBiZSAiIW1tY2ZnICYmIC4uLiIgdGhlbiBoZXJlLgoK PiAtLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L2h2bS9pby5oCj4gKysrIGIveGVuL2luY2x1ZGUv YXNtLXg4Ni9odm0vaW8uaAo+IEBAIC0xNjUsOSArMTY1LDE5IEBAIHZvaWQgc3RkdmdhX2RlaW5p dChzdHJ1Y3QgZG9tYWluICpkKTsKPiAgCj4gIGV4dGVybiB2b2lkIGh2bV9kcGNpX21zaV9lb2ko c3RydWN0IGRvbWFpbiAqZCwgaW50IHZlY3Rvcik7Cj4gIAo+IC0vKiBEZWNvZGUgYSBQQ0kgcG9y dCBJTyBhY2Nlc3MgaW50byBhIGJ1cy9zbG90L2Z1bmMvcmVnLiAqLwo+ICtzdHJ1Y3QgaHZtX21t Y2ZnIHsKPiArICAgIHN0cnVjdCBsaXN0X2hlYWQgbmV4dDsKPiArICAgIHBhZGRyX3QgYWRkcjsK PiArICAgIHVuc2lnbmVkIGludCBzaXplOwo+ICsgICAgdWludDE2X3Qgc2VnbWVudDsKPiArICAg IHVpbnQ4X3Qgc3RhcnRfYnVzOwo+ICt9Owo+ICsKPiArLyogRGVjb2RlIGEgUENJIHBvcnQgSU8g b3IgTU1DRkcgYWNjZXNzIGludG8gYSBidXMvc2xvdC9mdW5jL3JlZy4gKi8KPiAgdW5zaWduZWQg aW50IGh2bV9wY2lfZGVjb2RlX2FkZHIodW5zaWduZWQgaW50IGNmOCwgdW5zaWduZWQgaW50IGFk ZHIsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBjaV9zYmRmX3QgKnNiZGYp Owo+ICt1bnNpZ25lZCBpbnQgaHZtX21tY2ZnX2RlY29kZV9hZGRyKGNvbnN0IHN0cnVjdCBodm1f bW1jZmcgKm1tY2ZnLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhZGRy X3QgYWRkciwgcGNpX3NiZGZfdCAqc2JkZik7CgpUaGUgbGF0ZXN0IG5vdyB0aGUgY29tbWVudCBh bHNvIHdhbnRzIHRvIGluY2x1ZGUgInNlZy8iLCBJIHRoaW5rLgoKPiBAQCAtMTc4LDE1ICsxODgs MTggQEAgdm9pZCByZWdpc3Rlcl9nMm1fcG9ydGlvX2hhbmRsZXIoc3RydWN0IGRvbWFpbiAqZCk7 Cj4gIC8qIEhWTSBwb3J0IElPIGhhbmRsZXIgZm9yIHZQQ0kgYWNjZXNzZXMuICovCj4gIHZvaWQg cmVnaXN0ZXJfdnBjaV9wb3J0aW9faGFuZGxlcihzdHJ1Y3QgZG9tYWluICpkKTsKPiAgCj4gLS8q IEhWTSBNTUlPIGhhbmRsZXIgZm9yIFBDSSBNTUNGRyBhY2Nlc3Nlcy4gKi8KPiAtaW50IHJlZ2lz dGVyX3ZwY2lfbW1jZmdfaGFuZGxlcihzdHJ1Y3QgZG9tYWluICpkLCBwYWRkcl90IGFkZHIsCj4g LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IHN0YXJ0X2J1cywg dW5zaWduZWQgaW50IGVuZF9idXMsCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg dW5zaWduZWQgaW50IHNlZyk7Cj4gLS8qIERlc3Ryb3kgdHJhY2tlZCBNTUNGRyBhcmVhcy4gKi8K PiAtdm9pZCBkZXN0cm95X3ZwY2lfbW1jZmcoc3RydWN0IGRvbWFpbiAqZCk7Cj4gKy8qIEhWTSBQ Q0kgTU1DRkcgcmVnaW9ucyByZWdpc3RyYXRpb24uICovCj4gK2ludCBodm1fcmVnaXN0ZXJfbW1j Zmcoc3RydWN0IGRvbWFpbiAqZCwgcGFkZHJfdCBhZGRyLAo+ICsgICAgICAgICAgICAgICAgICAg ICAgIHVuc2lnbmVkIGludCBzdGFydF9idXMsIHVuc2lnbmVkIGludCBlbmRfYnVzLAo+ICsgICAg ICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBzZWcpOwoKQXMgLSBmcm9tIGEgaGllcmFy Y2h5IHBlcnNwZWN0aXZlIC0gdGhlIHNlZ21lbnQgaXMgbW9yZSBzaWduaWZpY2FudCwgY2FuCnlv dSBwdXQgaXQgYWhlYWQgb2YgdGhlIHN0YXJ0L2VuZCBidXMgbnVtYmVycyBwbGVhc2U/Cgo+ICt2 b2lkIGh2bV9mcmVlX21tY2ZnKHN0cnVjdCBkb21haW4gKmQpOwo+ICtjb25zdCBzdHJ1Y3QgaHZt X21tY2ZnICpodm1fbW1jZmdfZmluZChjb25zdCBzdHJ1Y3QgZG9tYWluICpkLCBwYWRkcl90IGFk ZHIpOwo+ICAKPiAgLyogQ2hlY2sgaWYgYW4gYWRkcmVzcyBpcyBiZXR3ZWVuIGEgTU1DRkcgcmVn aW9uIGZvciBhIGRvbWFpbi4gKi8KPiAtYm9vbCB2cGNpX2lzX21tY2ZnX2FkZHJlc3MoY29uc3Qg c3RydWN0IGRvbWFpbiAqZCwgcGFkZHJfdCBhZGRyKTsKPiArc3RhdGljIGlubGluZSBib29sIGh2 bV9pc19tbWNmZ19hZGRyZXNzKGNvbnN0IHN0cnVjdCBkb21haW4gKmQsIHBhZGRyX3QgYWRkcikK PiArewo+ICsgICAgcmV0dXJuIGh2bV9tbWNmZ19maW5kKGQsIGFkZHIpOwo+ICt9CgpIbW0sIHll dCBhbm90aGVyIGluc3RhbmNlIHdoZXJlIHRoZSBzaXplIG9mIGFuIGFjY2VzcyBkb2Vzbid0IG1h dHRlcgppbiBzdWNoIGEgcHJlZGljYXRlLiBJcyBpdCBhIGdvb2QgaWRlYSAob3IgaXMgdGhlcmUg YSBmYWlyIHJlYXNvbikKdG8gZXh0ZW5kIHRoaXMgYmFkIHByYWN0aWNlPyBCdXQgeWVzLCBJIGRv IHNlZSB0aGF0IHZwY2lfbW1jZmdfYWNjZXB0KCkKaGFzIG5vIHdheSB0byBwYXNzIGEgc2l6ZSBo ZXJlLCBhbmQgdGhhdCB5b3UgeW91IGVmZmVjdGl2ZWx5IG9ubHkKbW92ZSB0aGUgY29kZSBoZXJl LgoKSmFuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpY ZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRw czovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs