From: "syzzer (Code Review)" Date: Mon, 15 Dec 2025 16:00:39 +0000 In-Reply-To: References: Reply-To: steffan@...1856..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, max@...2606... Message-ID: <1d5a7750f5583926387befee0966826bc928a67f-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="Vg3PLgeQXq4="; charset=UTF-8 Subject: [Openvpn-devel] [XL] Change in openvpn[master]: Add support for Mbed TLS 4 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: MaxF Cc: plaisthos , openvpn-devel --Vg3PLgeQXq4= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: MaxF, plaisthos. syzzer has posted comments on this change by MaxF. ( http://gerrit.openvpn.= net/c/openvpn/+/1441?usp=3Demail ) Change subject: Add support for Mbed TLS 4 ...................................................................... Patch Set 3: (5 comments) Patchset: PS3: A few initials thoughts when glazing over part of the code. File src/openvpn/crypto_mbedtls.c: http://gerrit.openvpn.net/c/openvpn/+/1441/comment/ddbc1422_631be2a6?usp=3D= email : PS3, Line 88: /* TODO: Complete the table. */ Consider copying the table from the private mbedtls header file, might save= you some work. And complain with mbedtls that they broke a useful API... http://gerrit.openvpn.net/c/openvpn/+/1441/comment/35ed3edf_fa15f561?usp=3D= email : PS3, Line 204: return (int)cipher_info->key_bytes; key_bytes is already int, right? http://gerrit.openvpn.net/c/openvpn/+/1441/comment/eaf36ed8_1b9ab022?usp=3D= email : PS3, Line 292: ALLOC_OBJ_CLEAR(ctx, cipher_ctx_t); Good catch, adding the _CLEAR. http://gerrit.openvpn.net/c/openvpn/+/1441/comment/b63901cc_f7bfd9e1?usp=3D= email : PS3, Line 299: /* TODO: Log warning on errors? */ We can't handle the error here. If this errors out, looks to me like we are= in an invalid state. Consider ASSERT()'in out if it fails. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1441?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib251d546d993b96ed3bd8cb9111bcc627cdb0fae Gerrit-Change-Number: 1441 Gerrit-PatchSet: 3 Gerrit-Owner: MaxF Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: syzzer Gerrit-Attention: plaisthos Gerrit-Attention: MaxF Gerrit-Comment-Date: Mon, 15 Dec 2025 16:00:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No --Vg3PLgeQXq4= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: MaxF, plaisthos.

View = Change

5 comments:

  • Patchset:

    • Patch Set #3:

      A few initials= thoughts when glazing over part of the code.

  • File src/openvpn/crypto_mbedtls.c:

    • Patch Set #3, L= ine 88: /* TODO: Comple= te the table. */

      Consider copying the table from the private mbe= dtls header file, might save you some work. And complain with mbedtls that = they broke a useful API...

    • Patch Set #3, Line= 204: return (int)c= ipher_info->key_bytes;

      key_bytes is already int, right?

    • Patch Set #3, Line 292: ALLOC_OBJ_CLEAR(ctx, cipher_ctx_t);

      Patch Set #3= , Line 299: /* TODO= : Log warning on errors? */

      We can't handle the error here. = If this errors out, looks to me like we are in an invalid state. Consider A= SSERT()'in out if it fails.

To view, visit change 144= 1. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib251d546d993b96ed3bd8cb9111= bcc627cdb0fae
Gerrit-Change-Number: 1441
Gerrit-PatchSet: 3
Gerrit-Owner: MaxF <max@...2606...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: syzzer <steffan@...1856...> <= /div>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: MaxF <max@...2606...> =
Gerrit-Comment-Date: Mon, 15 Dec 2025 16:00:39= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
= --Vg3PLgeQXq4=--