From: "cron2 (Code Review)" Date: Fri, 28 Mar 2025 21:34:30 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., gianmarco@...2726..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <1d7c5223805ac5d9c2e620ecced6d88181227f41-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="RainoNgYXhk="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Fix FreeBSD-DCO and Multisocket interaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: its_Giaan Cc: plaisthos , flichtenheld , openvpn-devel --RainoNgYXhk= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, its_Giaan, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/925?usp=3Demail ) Change subject: Fix FreeBSD-DCO and Multisocket interaction ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: questions... File src/openvpn/dco.c: http://gerrit.openvpn.net/c/openvpn/+/925/comment/9d655d2e_4fc29dc7 : PS1, Line 263: if (ce->local_list) will this also catch clients that have no `--local` at all, just `--remote = ... tcp`? FreeBSD DCO also needs to be disabled for TCP clients. http://gerrit.openvpn.net/c/openvpn/+/925/comment/95331584_9525203f : PS1, Line 277: if (!proto_is_udp(ce->proto) && mode =3D=3D MODE_SERVER) this looks as if we need the fix for windows too... maybe keep & use the h= as_tcp_in_local_list() for this? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/925?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9b6359076a61ae2bbb8e5cea00e33969cb5f92cf Gerrit-Change-Number: 925 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: cron2 Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Fri, 28 Mar 2025 21:34:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --RainoNgYXhk= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, its_Giaan, plaistho= s.

View C= hange

3 comments:

    =
  • Patchset:

  • File src/openvpn/dco.c:

    • Patch Set #1, Line 263: if (ce->local_list)

      will this also catch cli= ents that have no `--local` at all, just `--remote ... tcp`? FreeBSD DCO a= lso needs to be disabled for TCP clients.

    • Patch Set #1, Li= ne 277: if (!proto_= is_udp(ce->proto) && mode =3D=3D MODE_SERVER)

      this looks as if we need= the fix for windows too... maybe keep & use the has_tcp_in_local_list= () for this?

To view, visit change 925. To unsubscribe= , or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9b6359076a61ae2bbb8e5cea00e= 33969cb5f92cf
Gerrit-Change-Number: 925
Gerrit-PatchSet: 1
Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: cron2 <gert@...1296...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Fri, 28 Mar 2025 21:34:30= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--RainoNgYXhk=--