From: "d12fk (Code Review)"
Date: Mon, 28 Apr 2025 06:12:00 +0000
In-Reply-To:
References:
Reply-To: heiko@...515..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...,
lstipakov@...277...
Message-ID: <1d955e3f3461ac94160219b1347e6aaf61360b1c-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="G4kNv21SMbY="; charset=UTF-8
Subject: [Openvpn-devel] [L] Change in openvpn[master]: dns: deal with
--dhcp-options when --dns is active
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: stipa , flichtenheld , plaisthos , openvpn-devel
--G4kNv21SMbY=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos, stipa.
d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/904?usp=3Demail )
Change subject: dns: deal with --dhcp-options when --dns is active
......................................................................
Patch Set 14:
(2 comments)
File src/openvpn/options.c:
http://gerrit.openvpn.net/c/openvpn/+/904/comment/d8e761d9_4194af85 :
PS14, Line 3504: memcpy(tt->domain_search_list, dhcp->domain_search=
_list, sizeof(tt->domain_search_list));
> C:\Users\lev\Projects\openvpn-build\src\openvpn\src\openvpn\options. [=E2=
=80=A6]
Done
http://gerrit.openvpn.net/c/openvpn/+/904/comment/842e2bc7_5ade9b3b :
PS14, Line 8350: }
> is "else" missing here? I have "--dhcp-option DNS 8.8.4. [=E2=80=A6]
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/904?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a
Gerrit-Change-Number: 904
Gerrit-PatchSet: 14
Gerrit-Owner: d12fk
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-Reviewer: stipa
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Attention: stipa
Gerrit-Comment-Date: Mon, 28 Apr 2025 06:12:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: stipa
Gerrit-MessageType: comment
--G4kNv21SMbY=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos, stipa. <=
/p>
View C=
hange
2 comments:
Done
Patch Set #14, L=
ine 8350: }
is "else" missing here? I have "--dhcp-op=
tion DNS 8.8.4. [=E2=80=A6]
Done
To view, visit <=
a href=3D"http://gerrit.openvpn.net/c/openvpn/+/904?usp=3Demail">change 904=
. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I635c4018fb43b5976a39b6a90cb=
2e9cb2570cd6a
Gerrit-Change-Number: 904
Gerrit-PatchSet: 14
Gerrit-Owner: d12fk <heiko@...515...> =
div>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-Reviewer: stipa <lstipakov@...277...=
>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Attention: stipa <lstipakov@...1663...=
.>
Gerrit-Comment-Date: Mon, 28 Apr 2025 06:12:00=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: stipa <lstipakov@...1664...=
7...>
Gerrit-MessageType: comment
--G4kNv21SMbY=--