Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68C91C433EF for ; Fri, 22 Apr 2022 12:47:42 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 30AAC83D4B; Fri, 22 Apr 2022 14:47:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="gO3U59le"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 96DE383D40; Fri, 22 Apr 2022 14:47:38 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20626.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eab::626]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 660E983D4B for ; Fri, 22 Apr 2022 14:47:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michals@xilinx.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=An8bMY3hBJeMROY6iN9FGT9wa2KHOouAh9dGM4+TTNeU03ifIGkdDEU1ySmfo+NP7V89kf2H7oQ03+O2wNTTl54ZpIYAIGzOS8iWLNlcvSL465K1b33tHqKHsmBicfWf3krKcWeW70Z0OgW8JrQkYoU+Hvchntjr89/+7jsb/z4ppVVTloxdGT15ZwL+OVOTfhLkrmoLspegn/Ywsx1s5ShZEMmI6kSCn2rxGS4MfMob9lYsWQ2CVK18suKOZ2VZ8r6PGyFVn4DkslFZHcleajjAv252AiY6Peo6mQbxo+LewpcEpRI13MsXpYlRMI2ogeJUf3Ty8SW2nJUeNuB8LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LRrTRW08rntKAril6z7TjkmG/TpQlYmkLFzjX6iE+ek=; b=FHm+5a41ihw2ncC9iweU/preyA5qcGBLbHfQx2k5IHjrbSWPrkPDAQO7ghJ9p4ITLm/KlDKCmpZ48ULXdDNAf228X/700Bd4KbbUDO/oY38xAEEwDo51OU6LKF39xz9R3qmywPAB2XXvBDXO8EUv72Qw5FWXae3ZC78W4RD/c0KupUBD9gSx8safUeu114zWFeqIxGAonkAC6CTUo0i2T5vGHJBRSlDT0jy9z6eL8AFW/jvZt4maoPf7RSKCgmmSoEmTIM+ATqW9+bgAAb1VrxRT/Ra1SJAu1NCfH6S9olf+s8z3z0AEKAU2zXtCZ3QEerkgfpA3z+V5CXrbUiqJrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=gmail.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LRrTRW08rntKAril6z7TjkmG/TpQlYmkLFzjX6iE+ek=; b=gO3U59leVoOb1AHdTE/z51kd0CUyEk2J7TFn+tj0kRYCopwG5gdcbKRLNnwas2sAAGnoYiWLmrvQIsdD5Qzj7HARa1lujrVKrkUuFtbr6dQLLDZ7HNIAWcgeYFULKo6cIUISDC/1wf54WizRmJGL7exC2vmVVpbyui53FlH5VCE= Received: from DS7PR03CA0058.namprd03.prod.outlook.com (2603:10b6:5:3b5::33) by BL0PR02MB3876.namprd02.prod.outlook.com (2603:10b6:207:4c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Fri, 22 Apr 2022 12:47:31 +0000 Received: from DM3NAM02FT027.eop-nam02.prod.protection.outlook.com (2603:10b6:5:3b5:cafe::80) by DS7PR03CA0058.outlook.office365.com (2603:10b6:5:3b5::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend Transport; Fri, 22 Apr 2022 12:47:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT027.mail.protection.outlook.com (10.13.5.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5186.14 via Frontend Transport; Fri, 22 Apr 2022 12:47:31 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 22 Apr 2022 05:47:30 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 22 Apr 2022 05:47:30 -0700 Envelope-to: ovpanait@gmail.com, u-boot@lists.denx.de, monstr@monstr.eu Received: from [10.254.241.50] (port=37164) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nhsh8-0000Gf-8n; Fri, 22 Apr 2022 05:47:30 -0700 Message-ID: <1da7c61e-9dae-a841-4e07-78ad841efd2a@xilinx.com> Date: Fri, 22 Apr 2022 14:47:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 04/10] microblaze: cache: improve icache Kconfig options Content-Language: en-US To: Ovidiu Panait , CC: Michal Simek , Michal Simek References: <20220411162634.69647-1-ovpanait@gmail.com> <20220411162634.69647-4-ovpanait@gmail.com> From: Michal Simek In-Reply-To: <20220411162634.69647-4-ovpanait@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a1fb6717-963e-489c-6064-08da245e444c X-MS-TrafficTypeDiagnostic: BL0PR02MB3876:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tqU2ZA62hsO0jXxtuFREQFS26Nq/vx38MeaN9pPBNms+p7GTgF1uTIlI3ngeD3EA/XAmPmaAuLnaAa/kPlJm3T4mKiQQqKqSbykQQOqSztZw73mW6fph7C+1BUsSxkCDngGObqXpoBKJa2tIS3P9yGGooB6un5q4j9tAHQBa9mY2iev5FCo2NpdbHyfGsoKsmStjagSTt8Dj4P/yyMdEAUp4Ga7XcOvFuI4L+TsduoEmLG43keKFbjDLGMDCTEvKrdSo2FMVS1uiE/f+rLUJgr2cI7M9D8PmUrQgO3q/qvSnEd8yPH8aXlOez0mr43C72KqgzxntTM9wiWq+4y3HxFoEsqwuvYj3k5UGwRQjeaEm1BYJo3kBj3pnRzhoraV0R/l/zZKtMWzX9jCxfJ+KSTWIUIj4aJC+AssPvhjtDEvYlTvlGW8xFkzTAWcOdHKtw+XdXgel0qLmkqpZzFnUdMR0Qn23HvyOD1daTBJrb5DMLsVrdozjFqyi9fXcPb5cT0AE9ubN0LCJwHefNvijvHe/MO2HEtbJSgVk65rLsAQpLTKmn0jI40X0YuTk4GqL8ClRF8ivGvgUydFtTmPzGGdH2q/xiGoBwT4X8WY1nmpMNtB59+q/IjI9ReMfHH5FO5If/RAOSoGoaHpwsEiuMwiRfhs5oMTZPA+tHGPd8C6b15V+R6P0NIBXIHLCowPAxGH+hsqyl3ODi0hEG8n1ebJbKSSI+TTPkafkPZzp9qg= X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch02.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(40460700003)(356005)(53546011)(2906002)(47076005)(26005)(336012)(70586007)(508600001)(2616005)(186003)(54906003)(70206006)(426003)(7636003)(4326008)(8676002)(31686004)(82310400005)(316002)(36860700001)(9786002)(31696002)(83380400001)(44832011)(8936002)(5660300002)(110136005)(36756003)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 12:47:31.6790 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a1fb6717-963e-489c-6064-08da245e444c X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT027.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB3876 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 4/11/22 18:26, Ovidiu Panait wrote: > Replace CONFIG_ICACHE with a Kconfig option more limited in scope - > XILINX_MICROBLAZE0_USE_WIC. It should be enabled if the processor supports > the "wic" (Write to Instruction Cache) instruction. It will be used to > guard "wic" invocations in microblaze cache code. > > Signed-off-by: Ovidiu Panait > --- > > arch/microblaze/Kconfig | 4 ---- > arch/microblaze/cpu/cache.c | 6 +++--- > board/xilinx/microblaze-generic/Kconfig | 7 +++++++ > 3 files changed, 10 insertions(+), 7 deletions(-) > > diff --git a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig > index 5a2e91104f..a25a95a013 100644 > --- a/arch/microblaze/Kconfig > +++ b/arch/microblaze/Kconfig > @@ -25,10 +25,6 @@ config TARGET_MICROBLAZE_GENERIC > > endchoice > > -config ICACHE > - bool "Enable icache support" > - default y > - > source "board/xilinx/Kconfig" > source "board/xilinx/microblaze-generic/Kconfig" > > diff --git a/arch/microblaze/cpu/cache.c b/arch/microblaze/cpu/cache.c > index 4e8e228a22..b6bbc215b3 100644 > --- a/arch/microblaze/cpu/cache.c > +++ b/arch/microblaze/cpu/cache.c > @@ -58,14 +58,14 @@ void flush_cache(ulong addr, ulong size) > { > int i; > for (i = 0; i < size; i += 4) { > - asm volatile ( > -#ifdef CONFIG_ICACHE > + if (CONFIG_IS_ENABLED(XILINX_MICROBLAZE0_USE_WIC)) { the same as I commented in 3/10. M