Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 912BCC3601E for ; Thu, 10 Apr 2025 08:56:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id ED85183AEE; Thu, 10 Apr 2025 10:56:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="QH9DprHk"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6773A83AF8; Thu, 10 Apr 2025 10:56:50 +0200 (CEST) Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 429E083AE9 for ; Thu, 10 Apr 2025 10:56:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=neil.armstrong@linaro.org Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-43cf0d787eeso6442745e9.3 for ; Thu, 10 Apr 2025 01:56:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744275408; x=1744880208; darn=lists.denx.de; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=mi4NZutOJVhbVIO8zZ+WMV2RQj152K6jx/1YmB9Htao=; b=QH9DprHkX7FgFQLE9KTV/QHtnpdSteDfxXM9ZeU/IqIXWVMVK+MEmMGH5DMSRLpo40 IDqTc0ZRkA/xHJ4jt8KRgvSdZ16xRX5yF+CSx1S/Y3nqpJbjIMe5mkezr6BmBR8YiDgP jmIZ2KADpjKcOOHAI0uIx4V1mLp/TrBp/1U18Se9BmH2ZuBqp1mGtMmmC/iQJF9/5jdC b96rO3l41JPN+Y/idctgWxR5E4j/qZRcuryuYoVKcJH/+iH1CMyPctpZpewaSAQznfcj F2+DgAxSxdDCbG8o5mrgzvjU8CBR9tKJO/VDORca9xWFJa/4dojkGM6ZjjKLzrdIrtgQ drRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744275408; x=1744880208; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mi4NZutOJVhbVIO8zZ+WMV2RQj152K6jx/1YmB9Htao=; b=cKeUTSk9LsMZUHkasAow9QHdoTDHa4PKi3OVcxG+ma/F1WrtxF7bWaDhcfrcu+khxe fNGj0DDzftrORs4F8bCSvePh331yC1Cw8WIeU+FLtF+D+ZVHmsaJbedvptAK8Q6xUfio Uii/w1F5M+dQO5v2gfGGdw1o9wr085I8Goidp9CEzzIN4bSO6PP1j6BmIdFBhEwbfPfe G33WuPYcmoubP+hNE/geMYYKL+HQqdaG3YaPz6nUMeS8femEiWJrQeDQXucDhOtugVM4 ArZHX30K/qZtm6NDnz+ZXM9Yk68rLiCcxZ5sgA/8m6VHzGNx9pgEZPk5bfOt2RKhuGjo Hkfw== X-Forwarded-Encrypted: i=1; AJvYcCXetD9mE4k5oXQnTOpvH6Xgc4sMcRBxs8MVI5cnF0FIg65x5gYtWTrz2SwIkLMTTIvah63xR2w=@lists.denx.de X-Gm-Message-State: AOJu0YyES77Jpdx5Y4fKFHzDuZOt7r2Ab4IOqhJCRIxxoxSN0jBBhp8w bL+HFRWDyMZS9YYtLxWD3/kNRaUG+iglixgP6KCugG3N/XzELo5uOKpi3WOhrw0= X-Gm-Gg: ASbGnctemU4ZOFd08b+sMhnTXO6wQpbn6Kv0NaheBi59w60o52jPBP6zD/m43UthLO7 Q7sCSdT6X8EMQ6/mINENVj19Tl4gaEsuTsfUjHHx9dfGa3+R2dzPq33bpB1mNA1RvNfvRHrKvHP mLLpAq3NtP/fN2/Aa95f7/sc08XfHt7yPWQyVSaRkRs5BEVhk1NBe6Qoqcak3IU0ICW/ydVWa5x naAvFJJ9GLuLsDImV5FFQhHHebQRq1xc2aJU1GbCk3TWY9poyksi97XgMScRAvpLUI2rRGsH8rd OQi5U1KiwwiIwHIWgzJJ6Ekpg6+thAIDM13lk2MXyzODa6pkH+wckDKcYEx+O+yATv0TCuDnXpE t66jxLAh9IzVP0H+r+A== X-Google-Smtp-Source: AGHT+IEjT/+JnjPVbWsS92HKfUwMmnN+S4qiPvfmyTlHXaO4ED8/5Ld3YKYw7fwPY3RZJ8Xb8/UOrA== X-Received: by 2002:a05:600c:4e09:b0:43d:db5:7b21 with SMTP id 5b1f17b1804b1-43f2ffa3bd8mr12594415e9.28.1744275407682; Thu, 10 Apr 2025 01:56:47 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:1a13:cd5d:5261:ebfe? ([2a01:e0a:3d9:2080:1a13:cd5d:5261:ebfe]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f205ec97csm48971635e9.6.2025.04.10.01.56.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Apr 2025 01:56:47 -0700 (PDT) Message-ID: <1daecfd3-0149-4d7f-bd2e-e75717692849@linaro.org> Date: Thu, 10 Apr 2025 10:56:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Subject: Re: [PATCH v2 2/2] phy: phy-qcom-qusb2: Fix USB PHY power on sequence To: Sumit Garg , u-boot@lists.denx.de, u-boot-qcom@groups.io Cc: caleb.connolly@linaro.org, trini@konsulko.com, alexeymin@postmarketos.org, Sumit Garg References: <20250410080027.208674-1-sumit.garg@kernel.org> <20250410080027.208674-3-sumit.garg@kernel.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20250410080027.208674-3-sumit.garg@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 10/04/2025 10:00, Sumit Garg wrote: > From: Sumit Garg > > Recent addition of support for SDM660 inadvertently broke USB PHY power > on sequence on RB1/RB2 and others with following error: > > starting USB... > Bus usb@4e00000: QUSB2PHY pll lock failed: status reg = 0 > qcom-qusb2-phy phy@1613000: PHY: Failed to power on phy@1613000: -16. > Can't power on PHY0 > probe failed, error -16 > No USB controllers found > > The root cause was the addition of flag se_clk_scheme_default which was > configured correctly for SDM660 but incorrect for all other supported > SoC. Fix that by properly assignment as per upstream Linux driver. > > Fixes: 475497dc3c15 ("phy: Add SDM660 support to Qualcomm QUSB2 phy") > Signed-off-by: Sumit Garg > --- > drivers/phy/qcom/phy-qcom-qusb2.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/phy/qcom/phy-qcom-qusb2.c b/drivers/phy/qcom/phy-qcom-qusb2.c > index cabd05bf5a6..d98f6108e69 100644 > --- a/drivers/phy/qcom/phy-qcom-qusb2.c > +++ b/drivers/phy/qcom/phy-qcom-qusb2.c > @@ -230,6 +230,7 @@ static const struct qusb2_phy_cfg sm6115_phy_cfg = { > .regs = sm6115_regs_layout, > > .has_pll_test = true, > + .se_clk_scheme_default = true, > .disable_ctrl = (CLAMP_N_EN | FREEZIO_N | POWER_DOWN), > .mask_core_ready = PLL_LOCKED, > .autoresume_en = BIT(3), > @@ -256,6 +257,7 @@ static const struct qusb2_phy_cfg qusb2_v2_phy_cfg = { > POWER_DOWN), > .mask_core_ready = CORE_READY_STATUS, > .has_pll_override = true, > + .se_clk_scheme_default = true, > .autoresume_en = BIT(0), > .update_tune1_with_efuse = true, > }; Reviewed-by: Neil Armstrong