From: "MaxF (Code Review)" Date: Thu, 22 Jan 2026 17:47:18 +0000 In-Reply-To: References: Reply-To: max@...2606..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., steffan@...1856... Message-ID: <1dda46e8c134bcfd70441adaa49aca6022f89e60-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="CmwGMhFitS8="; charset=UTF-8 Subject: [Openvpn-devel] [XL] Change in openvpn[master]: Add support for Mbed TLS 4 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , flichtenheld , syzzer , openvpn-devel --CmwGMhFitS8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos, syzzer. MaxF has posted comments on this change by MaxF. ( http://gerrit.openvpn.ne= t/c/openvpn/+/1441?usp=3Demail ) Change subject: Add support for Mbed TLS 4 ...................................................................... Patch Set 7: (3 comments) Patchset: PS5: > There is something wrong with connecting to an OpenSSL based OpeNVPN, e.g= . against community VPN: [=E2=80=A6] After looking around a bit, I found that this error code isn't exactly an e= rror, but it's meant to tell the application "there's a new session ticket,= if you want to do anything with that" (see e.g. https://github.com/Mbed-TL= S/mbedtls/issues/8749). In 3.6 it used to be the case that you had to opt in to that by calling mbe= dtls_ssl_conf_tls13_enable_signal_new_session_tickets but that function see= ms to be gone. Disabling session tickets altogether with mbedtls_ssl_conf_s= ession_tickets doesn't seem to do anything in TLS 1.3 either. I did a git g= rep on the mbedtls source, it doesn't seem to be checked at all in ssl_tls1= 3.c. So ultimately I decided to just treat this error code like WANT_READ or WAN= T_WRITE and keep running. With that change, I can connect an openvpn-mbedtl= s client to an openssl server, and ignoring the error doesn't seem to cause= any problems. Patchset: PS6: Fixed connecting an mbedtls client to an openssl server. Also updated READM= E.mbedtls. File src/openvpn/ssl_mbedtls.c: http://gerrit.openvpn.net/c/openvpn/+/1441/comment/9eb67876_ce448f68?usp=3D= email : PS5, Line 610: { > /Users/arne/oss/openvpn-git/src/openvpn/ssl_mbedtls. [=E2=80=A6] Fixed. The unused function is ifdefd out now. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1441?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib251d546d993b96ed3bd8cb9111bcc627cdb0fae Gerrit-Change-Number: 1441 Gerrit-PatchSet: 7 Gerrit-Owner: MaxF Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: syzzer Gerrit-Attention: plaisthos Gerrit-Attention: syzzer Gerrit-Comment-Date: Thu, 22 Jan 2026 17:47:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: plaisthos --CmwGMhFitS8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos, syzzer.

View = Change

3 comments:

  • Patchset:

    • Patch Set #5:

      The= re is something wrong with connecting to an OpenSSL based OpeNVPN, e.g. aga= inst community VPN: [=E2=80=A6]

      After looking around a b= it, I found that this error code isn't exactly an error, but it's m= eant to tell the application "there's a new session ticket, if you= want to do anything with that" (see e.g. https://github.com/Mbed-TLS/= mbedtls/issues/8749).

      In 3.6 it used to be the case that you had to opt= in to that by calling mbedtls_ssl_conf_tls13_enable_signal_new_session_tic= kets but that function seems to be gone. Disabling session tickets altogeth= er with mbedtls_ssl_conf_session_tickets doesn't seem to do anything in= TLS 1.3 either. I did a git grep on the mbedtls source, it doesn't see= m to be checked at all in ssl_tls13.c.

      So ultimately I decided to just = treat this error code like WANT_READ or WANT_WRITE and keep running. With t= hat change, I can connect an openvpn-mbedtls client to an openssl server, a= nd ignoring the error doesn't seem to cause any problems.

    =
  • Patchset:

    • Patch Set #6:

      Fixed conn= ecting an mbedtls client to an openssl server. Also updated README.mbedtls.=

  • File src/openvpn= /ssl_mbedtls.c:

    • Patch Set #5, Line 610: {

      /Users/arne/oss/openvpn-git/src/openvpn= /ssl_mbedtls. [=E2=80=A6]

      Fixed. The unused function is if= defd out now.

To view, visit change 1441. To unsubscr= ibe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib251d546d993b96ed3bd8cb9111= bcc627cdb0fae
Gerrit-Change-Number: 1441
Gerrit-PatchSet: 7
Gerrit-Owner: MaxF <max@...2606...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: syzzer <steffan@...1856...> <= /div>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: syzzer <steffan@...2115...= .>
Gerrit-Comment-Date: Thu, 22 Jan 2026 17:47:18= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <arne-openvp= n@...1227...>
= --CmwGMhFitS8=--