Received: from eggs.gnu.org ([2001:4830:134:3::10]:44590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bp0bl-0005q8-5X for qemu-devel@nongnu.org; Tue, 27 Sep 2016 18:12:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bp0bj-00046R-2o for qemu-devel@nongnu.org; Tue, 27 Sep 2016 18:12:12 -0400 References: <1474982001-20878-1-git-send-email-berrange@redhat.com> <1474982001-20878-8-git-send-email-berrange@redhat.com> <97b870b5-5236-eca6-97b6-c1c6377e0762@redhat.com> From: Eric Blake Message-ID: <1de3b1c2-e810-2460-c817-9dc78613ddaf@redhat.com> Date: Tue, 27 Sep 2016 17:12:04 -0500 MIME-Version: 1.0 In-Reply-To: <97b870b5-5236-eca6-97b6-c1c6377e0762@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="66lUQ4wOoWlHgXAOhIoforw38uVS16XSR" Subject: Re: [Qemu-devel] [PATCH v14 07/19] qapi: don't pass two copies of TestInputVisitorData to tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Markus Armbruster , Max Reitz , Paolo Bonzini , =?UTF-8?Q?Andreas_F=c3=a4rber?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --66lUQ4wOoWlHgXAOhIoforw38uVS16XSR From: Eric Blake To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Markus Armbruster , Max Reitz , Paolo Bonzini , =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: <1de3b1c2-e810-2460-c817-9dc78613ddaf@redhat.com> Subject: Re: [Qemu-devel] [PATCH v14 07/19] qapi: don't pass two copies of TestInputVisitorData to tests References: <1474982001-20878-1-git-send-email-berrange@redhat.com> <1474982001-20878-8-git-send-email-berrange@redhat.com> <97b870b5-5236-eca6-97b6-c1c6377e0762@redhat.com> In-Reply-To: <97b870b5-5236-eca6-97b6-c1c6377e0762@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/27/2016 05:10 PM, Eric Blake wrote: > On 09/27/2016 08:13 AM, Daniel P. Berrange wrote: >> The input_visitor_test_add() method was accepting an instance >> of 'TestInputVisitorData' and passing it as the 'user_data' >> parameter to test functions. The main 'TestInputVisitorData' >> instance that was actually used, was meanwhile being allocated >> automatically by the test framework fixture setup. >> >> Signed-off-by: Daniel P. Berrange >> --- >> tests/test-qobject-input-visitor.c | 76 ++++++++++++++++-------------= --------- >> 1 file changed, 32 insertions(+), 44 deletions(-) >> >=20 > Reviewed-by: Eric Blake >=20 Having said that, I note that ALL callers now pass NULL for user_data. If you plan on using it later in the series for something other than NULL for some of the (new?) tests added at that point, it would be wise to say so in the commit message; if not, I would suggest eliminating the parameter altogether. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --66lUQ4wOoWlHgXAOhIoforw38uVS16XSR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX6u60AAoJEKeha0olJ0NqUn0IAItwG/l2yDu05JwTXPwxHJSO Dn0HviCVbZWLf4Xy/0sNfjnAVQB57ZjJ+80fz1Bf59BdZFJ3u0AL0138V3rTPI0N c2A4BY3fwvPlC0g7tHQxP7Q20AoUmWP0Cl4yhFZFzr23XLY+6q99uIq7HeAzGrQC NK8zz6RlFRJMSzOdFT01Pwt5cwDoD0AuCyerln3GMWGFPjPo43UvgGTqkdVOhLe9 3gfcUsdC1KnNMqZKFK6JpjMy3/rZUzx3SycJJj1mpmS+AP3HhHvuh8pPhiWVs7ew jxS3RTJhIwtfUCC7Z+Zyzg5CHvJkxi9TbBSF+5qORqeg/9bPUECi4yK6RrieCtM= =EtPj -----END PGP SIGNATURE----- --66lUQ4wOoWlHgXAOhIoforw38uVS16XSR--