From: "cron2 (Code Review)"
Date: Wed, 29 Jan 2025 10:07:39 +0000
In-Reply-To:
References:
Reply-To: gert@...1296..., arne-openvpn@...1227...,
gianmarco@...2726..., openvpn-devel@lists.sourceforge.net,
frank@...2641..., a@...2181...
Message-ID: <1e05ab2f17f45586bcee62f12370cb2cfd781ece-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="xIZeh9KLR+k="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: mroute/management:
fix uninitialized variable (UNINIT)
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: its_Giaan
Cc: plaisthos , flichtenheld , openvpn-devel
--xIZeh9KLR+k=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, its_Giaan, ordex, plais=
thos.
cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/880?usp=3Demail )
Change subject: mroute/management: fix uninitialized variable (UNINIT)
......................................................................
Patch Set 3: Code-Review-1
(4 comments)
Patchset:
PS3:
too much enthusiasm
File src/openvpn/manage.c:
http://gerrit.openvpn.net/c/openvpn/+/880/comment/a30bd653_c1d4c73d :
PS3, Line 597: n_killed =3D (*man->persist.callback.kill_by_cn)=
(man->persist.callback.arg, p2);
Ah, no, not that one :-) for CN we only have p1
http://gerrit.openvpn.net/c/openvpn/+/880/comment/47dd9eb5_409a4c6d :
PS3, Line 600: msg(M_CLIENT, "SUCCESS: common name '%s' fou=
nd, %d client(s) killed", p2, n_killed);
too enthusiastic
http://gerrit.openvpn.net/c/openvpn/+/880/comment/986c2548_b64f20f8 :
PS3, Line 604: msg(M_CLIENT, "ERROR: common name '%s' not f=
ound", p2);
and here
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/880?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4be0ff4d308213d2ef8ba66bd3178eee1f60fff1
Gerrit-Change-Number: 880
Gerrit-PatchSet: 3
Gerrit-Owner: its_Giaan
Gerrit-Reviewer: cron2
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-CC: ordex
Gerrit-Attention: plaisthos
Gerrit-Attention: its_Giaan
Gerrit-Attention: flichtenheld
Gerrit-Attention: ordex
Gerrit-Comment-Date: Wed, 29 Jan 2025 10:07:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--xIZeh9KLR+k=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, its_Giaan, ordex, p=
laisthos.
Patch set 3:Code-Review -1=
Vi=
ew Change
4 comments:
=
To view, visit change 880. To unsubscribe, or for help writing=
mail filters, visit setting=
s.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4be0ff4d308213d2ef8ba66bd31=
78eee1f60fff1
Gerrit-Change-Number: 880
Gerrit-PatchSet: 3
Gerrit-Owner: its_Giaan <gianmarco@...2786...=
..>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-CC: ordex <a@...2181...>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: its_Giaan <gianmarco@...1665...=
726...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Attention: ordex <a@...2181...> <=
/div>
Gerrit-Comment-Date: Wed, 29 Jan 2025 10:07:39=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--xIZeh9KLR+k=--