From: "flichtenheld (Code Review)" Date: Fri, 27 Dec 2024 16:25:24 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, lstipakov@...277... Message-ID: <1e1a64542a7b34462ca05b52cb365d90c25e1afb-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="uJdJCApiW28="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Add methods to read/write packet ids for epoch data List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: stipa , openvpn-devel --uJdJCApiW28= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/803?usp=3Demail ) Change subject: Add methods to read/write packet ids for epoch data ...................................................................... Patch Set 8: Code-Review-1 (3 comments) File src/openvpn/packet_id.h: http://gerrit.openvpn.net/c/openvpn/+/803/comment/1049acea_ac1fd539 : PS8, Line 49: /** Maks of the bits that make out the epoch in the packet co= unter */ "Maks" -> "Mask". "make out" -> "masks out"? http://gerrit.openvpn.net/c/openvpn/+/803/comment/8ca67c36_92924ef3 : PS8, Line 333: * @param buf buffer to write the packet id/epcoh to "epoch" File src/openvpn/packet_id.c: http://gerrit.openvpn.net/c/openvpn/+/803/comment/7a433205_650c3d7a : PS8, Line 684: * integer contain our counter but the upper two bytes a= re always 0 */ This is confusing. The point where we convert to network order the epoch is= already joined, so the bytes aren't 0, are they? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/803?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2a104decdb1e77a460f7a6976bcd0560b67a07b5 Gerrit-Change-Number: 803 Gerrit-PatchSet: 8 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-CC: stipa Gerrit-Attention: plaisthos Gerrit-Attention: stipa Gerrit-Comment-Date: Fri, 27 Dec 2024 16:25:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --uJdJCApiW28= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos, stipa.

Patch set 8:Code-Review -1=

Vi= ew Change

3 comments:

  • File src/openvpn/packet_id.h:

  • File src/openvpn/p= acket_id.c:

    • Patch S= et #8, Line 684: *= integer contain our counter but the upper two bytes are always 0 */=

      This is conf= using. The point where we convert to network order the epoch is already joi= ned, so the bytes aren't 0, are they?

To view= , visit c= hange 803. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2a104decdb1e77a460f7a6976bc= d0560b67a07b5
Gerrit-Change-Number: 803
Gerrit-PatchSet: 8
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: stipa <lstipakov@...277...> <= /div>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: stipa <lstipakov@...1663...= .>
Gerrit-Comment-Date: Fri, 27 Dec 2024 16:25:24= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--uJdJCApiW28=--