From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH v3] drm/amdgpu: update documentation for amdgpu_drv.c Date: Thu, 5 Jul 2018 16:58:15 +0200 Message-ID: <1e6f00fb-026a-5fbf-effa-14567a68c1cb@gmail.com> References: <1530728444-32347-1-git-send-email-sonny.jiang@amd.com> <7279fc27-0bba-a818-7682-f4e06815b8da@gmail.com> <131f66f1-8871-de93-2c3a-50b8c15cb9d8@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1357405920==" Return-path: In-Reply-To: <131f66f1-8871-de93-2c3a-50b8c15cb9d8-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?Q?Christian_K=c3=b6nig?= , "Jiang, Sonny" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" This is a multi-part message in MIME format. --===============1357405920== Content-Type: multipart/alternative; boundary="------------8635821DE7AF295D44F86F50" Content-Language: en-US This is a multi-part message in MIME format. --------------8635821DE7AF295D44F86F50 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Mhm, double checking that I now knew why my memory fooled me: We use 0 as infinite timeout in radeon. Maybe we should change amdgpu to do the same and reject negative values. Christian. Am 05.07.2018 um 16:54 schrieb Christian König: > Sounds like my memory fooled me, but we should document that as well. > > Christian. > > Am 05.07.2018 um 16:47 schrieb Jiang, Sonny: >> >> Change it to, >> >> Value 0 is invalidated, will be adjusted to 10000. Negative values >> mean 'infinite timeout' (MAX_JIFFY_OFFSET). >> >> >> Thanks, >> >> Sonny >> >> ------------------------------------------------------------------------ >> *From:* Christian König >> *Sent:* Thursday, July 5, 2018 3:30:28 AM >> *To:* Jiang, Sonny; amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org >> *Subject:* Re: [PATCH v3] drm/amdgpu: update documentation for >> amdgpu_drv.c >> Am 04.07.2018 um 20:20 schrieb Sonny Jiang: >> > [SNIP] >> > >> > +/** >> > + * DOC: lockup_timeout (int) >> > + * Set GPU scheduler timeout value in ms. It must be > 0.  The >> default is 10000. >> > + */ >> >   MODULE_PARM_DESC(lockup_timeout, "GPU lockup timeout in ms > 0 >> (default 10000)"); >> >   module_param_named(lockup_timeout, amdgpu_lockup_timeout, int, 0444); >> >> Actually the description here is incorrect, a value of 0 is handled as >> infinite timeout IIRC. Please fix while at it. >> >> Apart from that the patch is Acked-by: Christian König >> . >> >> Christian. > > > > _______________________________________________ > amd-gfx mailing list > amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx --------------8635821DE7AF295D44F86F50 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit
Mhm, double checking that I now knew why my memory fooled me: We use 0 as infinite timeout in radeon.

Maybe we should change amdgpu to do the same and reject negative values.

Christian.

Am 05.07.2018 um 16:54 schrieb Christian König:
Sounds like my memory fooled me, but we should document that as well.

Christian.

Am 05.07.2018 um 16:47 schrieb Jiang, Sonny:

Change it to,

Value 0 is invalidated, will be adjusted to 10000.  Negative values mean 'infinite timeout' (MAX_JIFFY_OFFSET).


Thanks,

Sonny


From: Christian König <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Sent: Thursday, July 5, 2018 3:30:28 AM
To: Jiang, Sonny; amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH v3] drm/amdgpu: update documentation for amdgpu_drv.c
 
Am 04.07.2018 um 20:20 schrieb Sonny Jiang:
> [SNIP]
>  
> +/**
> + * DOC: lockup_timeout (int)
> + * Set GPU scheduler timeout value in ms. It must be > 0.  The default is 10000.
> + */
>   MODULE_PARM_DESC(lockup_timeout, "GPU lockup timeout in ms > 0 (default 10000)");
>   module_param_named(lockup_timeout, amdgpu_lockup_timeout, int, 0444);

Actually the description here is incorrect, a value of 0 is handled as
infinite timeout IIRC. Please fix while at it.

Apart from that the patch is Acked-by: Christian König
<christian.koenig-5C7GfCeVMHo@public.gmane.org>.

Christian.



_______________________________________________
amd-gfx mailing list
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

--------------8635821DE7AF295D44F86F50-- --===============1357405920== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBt YWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg== --===============1357405920==--