From: "MaxF (Code Review)" Date: Sat, 28 Dec 2024 17:34:37 +0000 In-Reply-To: References: Reply-To: max@...2606..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <1e7b2126341ea0b79ab486dc15cf56792a7492a3-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="/vA0t64NZ9Y="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: Implement methods to generate and manage OpenVPN Epoch keys List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: flichtenheld , openvpn-devel --/vA0t64NZ9Y= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/open= vpn/+/804?usp=3Demail ) Change subject: Implement methods to generate and manage OpenVPN Epoch keys ...................................................................... Patch Set 9: (12 comments) Patchset: PS9: Reviewed until crypto_epoch.h, will continue later File src/openvpn/crypto.h: http://gerrit.openvpn.net/c/openvpn/+/804/comment/a432af93_97a33d7a : PS9, Line 175: /** the epoch of the key is if it was generated as epoch dat= a key material */ I think you mean: The epoch of the key, if it was generated as epoch data k= ey material. (Implying, it's undefined if this is a different kind of key?) http://gerrit.openvpn.net/c/openvpn/+/804/comment/735a8e52_5784bd7e : PS9, Line 223: is this? http://gerrit.openvpn.net/c/openvpn/+/804/comment/a6671a3f_87bca2ec : PS9, Line 315: key keys http://gerrit.openvpn.net/c/openvpn/+/804/comment/5f52e18e_e35d296c : PS9, Line 316: to switch also sending key to also switch the sending key? http://gerrit.openvpn.net/c/openvpn/+/804/comment/68672759_37e827d3 : PS9, Line 324: switch switched? http://gerrit.openvpn.net/c/openvpn/+/804/comment/7c80d6b3_104e8e59 : PS9, Line 524: @param epoch Epoch read from packet or 0 when epoch is not u= sed. That's not an argument of the function. File src/openvpn/crypto_epoch.h: http://gerrit.openvpn.net/c/openvpn/+/804/comment/ced0bc22_010e9c3f : PS9, Line 72: * @param epoch_key Epoch key to be used : * @param key Destination for the generated data key wrong order compared to the function. http://gerrit.openvpn.net/c/openvpn/+/804/comment/cb952e40_38a4c3a6 : PS9, Line 91: using uses http://gerrit.openvpn.net/c/openvpn/+/804/comment/480f9270_6b023e63 : PS9, Line 96: a for the receive key? http://gerrit.openvpn.net/c/openvpn/+/804/comment/3dba7c21_2b0cdd56 : PS9, Line 103: send_epoch_keyt send_epoch_key http://gerrit.openvpn.net/c/openvpn/+/804/comment/44263987_947e608e : PS9, Line 118: * @param e1_send The E1 send epoch key derived by TLS-EKM : * @param e1_recv The E1 receive epoch key derived by TLS= -EKM incomplete parameters -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/804?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id7d6a576ca8c9560cb2dfae82fc62175820e9b80 Gerrit-Change-Number: 804 Gerrit-PatchSet: 9 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: MaxF Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Sat, 28 Dec 2024 17:34:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --/vA0t64NZ9Y= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

View C= hange

12 comments:

To view, visit change 804. To unsubscribe, or= for help writing mail filters, visit settings.

<= /div>
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id7d6a576ca8c9560cb2dfae82fc= 62175820e9b80
Gerrit-Change-Number: 804
Gerrit-PatchSet: 9
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: MaxF <max@...2606...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Sat, 28 Dec 2024 17:34:37= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--/vA0t64NZ9Y=--