From: "flichtenheld (Code Review)" Date: Mon, 30 Jun 2025 14:10:09 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <1e8b05165ddd92853e2ecdd67063aabcb989199d-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="P57V4h9XdD0="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: packet_id: Fix build with --disable-debug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --P57V4h9XdD0= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1071?usp=3Demail to review the following change. Change subject: packet_id: Fix build with --disable-debug ...................................................................... packet_id: Fix build with --disable-debug Broken since commit bc62a9a02cb7365a678bcd3f2faf537a420cc5a0 "Add methods to read/write packet ids for epoch data" Change-Id: I3bed9c7aafee8e62ddae14c0d3e21cf4c146a37c Signed-off-by: Frank Lichtenheld --- M src/openvpn/packet_id.c 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/71/1071/1 diff --git a/src/openvpn/packet_id.c b/src/openvpn/packet_id.c index c8dae32..76a81c6 100644 --- a/src/openvpn/packet_id.c +++ b/src/openvpn/packet_id.c @@ -673,6 +673,8 @@ gc_free(&gc); } +#endif /* ifdef ENABLE_DEBUG */ + uint16_t packet_id_read_epoch(struct packet_id_net *pin, struct buffer *buf) { @@ -711,6 +713,3 @@ return buf_write(buf, &net_id, sizeof(net_id)); } - - -#endif /* ifdef ENABLE_DEBUG */ -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1071?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3bed9c7aafee8e62ddae14c0d3e21cf4c146a37c Gerrit-Change-Number: 1071 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-MessageType: newchange --P57V4h9XdD0= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

packet_id: Fix build with --disable-debug

Broken sinc= e commit
bc62a9a02cb7365a678bcd3f2faf537a420cc5a0
"Add methods t= o read/write packet ids for epoch data"

Change-Id: I3bed9c7aafe= e8e62ddae14c0d3e21cf4c146a37c
Signed-off-by: Frank Lichtenheld <frank= @...2641...>
---
M src/openvpn/packet_id.c
1 file changed, 2 in= sertions(+), 3 deletions(-)

git pull ssh://gerrit.openvpn.net:294=
18/openvpn refs/changes/71/1071/1
diff --git a/src/openvpn/packet_i=
d.c b/src/openvpn/packet_id.c
index c8dae32..76a81c6 100644=
--- a/src/openvpn/packet_id.c
+++ b/src/op= envpn/packet_id.c
@@ -673,6 +673,8 @@
= gc_free(&gc);
}

+#endif /* ifdef ENABLE_DEBUG */+
uint16_t
packet_id_read_epoch(struct packet_id_net *pin, struct buff= er *buf)
{
@@ -711,6 +713,3 @@
<= span>

return buf_write(buf, &net_id, sizeof(net_i= d));
}
-
-
-#endif /* ifdef ENABLE_DEBUG */

To view, visit change 1071. To unsubscribe, or for = help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3bed9c7aafee8e62ddae14c0d3e= 21cf4c146a37c
Gerrit-Change-Number: 1071
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-MessageType: newchange
--P57V4h9XdD0=--