Message-ID: <1e9a8fb5-22e3-847a-6bcd-98ce8e3f893c@...1227...> Date: Sat, 4 Feb 2023 14:22:30 +0100 MIME-Version: 1.0 Content-Language: en-GB References: <20230128223421.2207802-1-selva.nair@...277...> <20230128223421.2207802-5-selva.nair@...277...> <5fbbea42-096a-f9e9-f230-ccc526e973e2@...1227...> From: Arne Schwabe In-Reply-To: Subject: Re: [Openvpn-devel] [PATCH 4/4] cryptoapi.c: simplify parsing of thumbprint hex string List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit To: Selva Nair Cc: Frank Lichtenheld , openvpn-devel@lists.sourceforge.net > Thanks a lot for that. > > By adding win32-util.c and -lws2_32 where required, I can now build > almost all tests using the autotools framework --- cmocka had to be > cross-compiled using cmake which is a pain. > I do not particularly like cmake though it'sĀ convenient for Windows MSVC > build, so sticking to autoconf/automake for now. Unless the "consensus" > is to move to cmake --- hope not :) No. Other OpenVPN contributers have spoken out against CMake, so I never bothered to clean it up, so that the current cmake file is a mixture of clean stuff and hacks. It is pretty useful for me for doing remote build/debugging with Clion under macOS/Linux and also when I use Visual Studio or Clion under Windows. Even though I think that adding Cmake as unsupported build method is a good idea. This would allow others to have the same option/advantages like me that prefer cmake to autoconf/automake, this also does not seem to have a consensus, so I just maintain it for myself in my branch. Arne