Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3ADA9C433F5 for ; Thu, 21 Apr 2022 15:27:09 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 68EA783D62; Thu, 21 Apr 2022 17:27:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="yNEZPuH8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 846F883BBE; Thu, 21 Apr 2022 17:27:05 +0200 (CEST) Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C4D4E83D7A for ; Thu, 21 Apr 2022 17:27:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=prvs=01100d5851=patrice.chotard@foss.st.com Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23LFPCsA031810; Thu, 21 Apr 2022 17:26:55 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=qmwChv4DbtBr5bb91YXsV5GaAGhY1Y7Sh4ySmLQ6w1I=; b=yNEZPuH8n82TJK/VRxHTq9+vSIYqL+fuhrpBCdoIH+AgnS1SNDC0RlV2Zuj9gIA6y4A+ GFirkJTfnYtcxGq9cCPlrU/ZkF943RJWtKve0taZAyjOXKVDhBu1BmtMadK9MbAndY7C fON99fHgNpEFKj20wBDeZx6ROGZQE5rDJdRQL1tHWcjLshxkEqESpgADSUjMOOQiPtF2 dnk5jtmxRhWH0CbD6peznbCwN9a5K0UKc/w2vxBDvkKmv2kBSQNcRyOBVjLUUnzUMzm+ WTuje0AGITdHm+xrckZSgF7JekmeTWPMWXAagU5A0rPDZKrDlDWh4kbges+UnmDFt1Yk OA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3ffpqh3u2g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Apr 2022 17:26:55 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 53D8210002A; Thu, 21 Apr 2022 17:26:54 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 4C88922ECFA; Thu, 21 Apr 2022 17:26:54 +0200 (CEST) Received: from [10.201.21.201] (10.75.127.49) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Thu, 21 Apr 2022 17:26:53 +0200 Message-ID: <1eb6ece0-e62c-e63b-da81-6455a6a18c5b@foss.st.com> Date: Thu, 21 Apr 2022 17:26:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] led: Configure LED default-state on boot Content-Language: en-US To: Marek Vasut , CC: Alex Nemirovsky , Patrick Delaunay , Philippe Reynes , Sean Anderson , Simon Glass , Steven Lawrance References: <20220403232327.720900-1-marex@denx.de> <051116fd-2619-fe62-cd1d-6b1ab64e9949@foss.st.com> From: Patrice CHOTARD In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.49] X-ClientProxiedBy: SFHDAG2NODE1.st.com (10.75.127.4) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-21_02,2022-04-21_01,2022-02-23_01 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 4/21/22 17:18, Marek Vasut wrote: > On 4/21/22 17:09, Patrice CHOTARD wrote: >> Hi Marek > > Hi, > >> I tested the current U-Boot master branch (22bfaa1f673ab5442dfb9778eea4c9a18dee42d0) >> This patch is breaking the boot sequence on stm32mp157c-dk2. > > Breaking it ... how ? What happens, hang ? Here is the boot log : U-Boot SPL 2022.04-00827-g22bfaa1f67 (Apr 21 2022 - 17:22:47 +0200) RAM: DDR3-DDR3L 16bits 533000kHz WDT: Started watchdog@5a002000 with servicing (32s timeout) U-Boot 2022.04-00827-g22bfaa1f67 (Apr 21 2022 - 17:22:47 +0200) CPU: STM32MP157CAC Rev.B Model: STMicroelectronics STM32MP157C-DK2 Discovery Board Board: stm32mp1 in basic mode (st,stm32mp157c-dk2) Board: MB1272 Var2.0 Rev.C-01 DRAM: 512 MiB Clocks: - MPU : 0 MHz - MCU : 0 MHz - AXI : 0 MHz - PER : 0 MHz - DDR : 0 MHz clock rate is 0 clock rate is 0 clock rate is 0 clock rate is 0 clock rate is 0 cloc What worried me is that all clocks are set to 0 (MPU/MCU/AXI ....)...no direct link with the led-uclass update. For information, if i comment the device_probe(dev) in led_post_bind(), it avoid the hang. Thanks Patrice