Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8154FC433E6 for ; Mon, 31 Aug 2020 15:20:52 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D2E22083E for ; Mon, 31 Aug 2020 15:20:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D2E22083E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kClbq-0004sy-5K; Mon, 31 Aug 2020 15:20:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kClbo-0004st-MJ for xen-devel@lists.xenproject.org; Mon, 31 Aug 2020 15:20:36 +0000 X-Inumbo-ID: 8676fe83-e234-4d6e-8659-d138c871376f Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8676fe83-e234-4d6e-8659-d138c871376f; Mon, 31 Aug 2020 15:20:35 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D34AAB5AF; Mon, 31 Aug 2020 15:20:34 +0000 (UTC) Subject: Re: [PATCH v2 2/8] x86/svm: silently drop writes to SYSCFG and related MSRs To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: xen-devel@lists.xenproject.org, Andrew Cooper , Wei Liu References: <20200820150835.27440-1-roger.pau@citrix.com> <20200820150835.27440-3-roger.pau@citrix.com> <52cde027-e7c2-3ca7-3d7e-7abfe19198da@suse.com> <20200831143747.GD753@Air-de-Roger> From: Jan Beulich Message-ID: <1ee3bf3d-ce6c-c110-9ab6-2bf9cb81d334@suse.com> Date: Mon, 31 Aug 2020 17:20:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200831143747.GD753@Air-de-Roger> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 31.08.2020 16:37, Roger Pau Monné wrote: > On Thu, Aug 27, 2020 at 05:03:50PM +0200, Jan Beulich wrote: >> On 20.08.2020 17:08, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/hvm/svm/svm.c >>> +++ b/xen/arch/x86/hvm/svm/svm.c >>> @@ -1917,6 +1917,21 @@ static int svm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) >>> goto gpf; >>> break; >>> >>> + case MSR_K8_TOP_MEM1: >>> + case MSR_K8_TOP_MEM2: >>> + *msr_content = 0; >>> + break; >> >> Any reason you don't fold this with ... >> >>> + case MSR_K8_SYSCFG: >>> + /* >>> + * Return MtrrFixDramEn: albeit the current emulated MTRR >>> + * implementation doesn't support the Extended Type-Field Format having >>> + * such bit set is common on AMD hardware and is harmless as long as >>> + * MtrrFixDramModEn isn't set. >>> + */ >>> + *msr_content = K8_MTRRFIXRANGE_DRAM_ENABLE; >>> + break; >>> + >>> case MSR_K8_VM_CR: >>> *msr_content = 0; >>> break; >> >> ... this existing case, and ... > > I was trying to sort them by value, but I can certainly merge this and > the case below. Sorting by number is helpful as a secondary criteria, but I think groups of registers wanting to be handled the same should go together. This is especially looking forward, where otherwise many instances of the same (trivial or not) logic may appear. Jan