Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F036C28C87C for ; Thu, 10 Jul 2025 08:28:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752136141; cv=none; b=ME2/y2MdTkb4VY55AF6eFBgO98U/xrH0FkFCyjS8wns0wdjfJyxm8zgBuXRwg1nAJaYI0AX5oOyowcgtO8jFHQ9ICzDSADd/rJPOngNgBxjHk9d47AV3L5/XQ4l66XPzvrbA+PidP4fgZS/xhp3HvFDvN7+F/hDc//V0SgunXvk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752136141; c=relaxed/simple; bh=5gs72OSD8X2xBF0PUccLQVo8CMzpQb4kbASHqWFDX7U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j544z02XECFoY8aglqrzU4KijSnMXMBCAknpDP7/xMfklirBdJVJTY+GCYwcwh0Lq4U+9ORGUrnYYV+8TjBuGt7pVhvhmvNxvE+99jB2JIc2xLq8fqQitayl6ovz0ST2PqBmwWw6e7OooMgrKAkaxhMY01P9mEsoWB9CjknvtWg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YLu7FFYG; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YLu7FFYG" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-60c6fea6742so1286568a12.1 for ; Thu, 10 Jul 2025 01:28:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752136138; x=1752740938; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=YZ7a5wxKov3XctJDNYsU1Y+3qqy9QlhBDvjublz0jdw=; b=YLu7FFYG6djfZ6bf8K/6UZ4GmWs73mVLTmY2TE4PHad4Il8jQuz+aoMSX5dgR6eH7y yvAYEjnztIMyjqKO8CNfaYlDTahW7iIr+MWKQfmg/8VjA5C78vk9KzrlpqSvA68VWGVB em4/JMwBH1thphbpcN4DGAJdX4nOtbgKZnD/eSxz+FUB0+qQDlul0okXbRgDdmvAAMht 6/ho4pUbgl4oEedfVwyxZpyxQqD10Gqee33nkQQuXG1xXtePtasLcjwOHy/tdQhh6cV4 1vgqy7VfpDRWU0aSXejLdsl+aucTChpKf3mfvTCy2JhTM7fSSFmrnyzw//tbZIuEQ7MY coZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752136138; x=1752740938; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YZ7a5wxKov3XctJDNYsU1Y+3qqy9QlhBDvjublz0jdw=; b=SqwjGa68Gscf7Yq9ntFkNAxPnYLirysQkZSkMz7W9uFZKbJVHTsz+ye8GDLXCLzhui xzp2nkMwoB5BR00esc8BM+uJK3vNVg2YW5ps5wwSa4Rh6bQmcnBy6Fq2lbHP3+s+mqpx Slo17+SS8wZllFqoe6L8aUzKMopHay7YS6g0/NM9jh35Z9CIQxlWja1bpd3EPcbzTXNy ks+gV98i0S8I/pPfxSMvvsxFO9sawgeKMwnpBu0zV8WEB5nRAcN+MukFqqTZrEhjnDDP 4g/W6wvk/TZHYq0NU+6LhzMODScDrCCetCqryJlmFgrZGXyiYOeBRP9qlebwbtFpLG16 Y53Q== X-Forwarded-Encrypted: i=1; AJvYcCXUK4PLImki4AW7U76NGy9vonjHMAAQqOMkxcqQa8D7daB2+KJ3laGQhxnjQ371NsOlvijcXndBEA==@lists.linux.dev X-Gm-Message-State: AOJu0Ywfl9DoWfzhJzNw7PsIrPC1agJb0V6S9I1leOgdWYOhTYU8EqM6 SG4Cy9TkFJDakMliqW12ijvbNPmKv7sHPQh3UkRfg6HStCErEjTLwL4n X-Gm-Gg: ASbGncvPDlvLkm5VdoD0Ck4f4zDpo00yvra9XY39dqfvy4VVXSxK/Vz7we1TWWv3dho HC55T1HF7iKo3OAmgY4sJjN9bb/SmrpumwqPw8gkRUrTN9FdZwR+/1Gw4ZW6NCTXnKgqll/PAs1 r2des8J0vtQ7ZNGEUwtqzF5tYC9rY+dxBByH60zpClUy7BDe1JXbBj4JOA80T2yaaWByAkj1byO d/qoJeL8AWbHFgz2uy/SAbEyrjmhVjST/7DT84S8XkFloeop8Ia7PiDB8VwX6qgOXC7fmfYJZMK V2lTSgOPtOrZ6VbaRVMxYTDaejalc4JMt8noS/qvB8tMhCNClFNuyWXO9KqtelCBYnfsrBXwsG8 YRBZlZK0UQxxb+mmyvQ9i X-Google-Smtp-Source: AGHT+IHF010t9VV34/hZjJFBIxD6ohmpe910yVDqzmljymhVWQ3VcYBkGotu9f+dxKVp6Y9iTqS3WQ== X-Received: by 2002:a05:6402:26cb:b0:607:6fd3:374f with SMTP id 4fb4d7f45d1cf-611c166cedbmr2345415a12.20.1752136137225; Thu, 10 Jul 2025 01:28:57 -0700 (PDT) Received: from [147.251.42.106] (fosforos.fi.muni.cz. [147.251.42.106]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-611c9524806sm543200a12.22.2025.07.10.01.28.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Jul 2025 01:28:56 -0700 (PDT) Message-ID: <1ee8338a-b19a-409a-bbe6-2068893b8abc@gmail.com> Date: Thu, 10 Jul 2025 10:28:55 +0200 Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] dm-verity: remove support for asynchronous hashes To: Eric Biggers , dm-devel@lists.linux.dev, Alasdair Kergon , Mike Snitzer , Mikulas Patocka Cc: linux-kernel@vger.kernel.org, Gilad Ben-Yossef , Ard Biesheuvel , "Jason A . Donenfeld" , Sami Tolvanen References: <20250709190902.49554-1-ebiggers@kernel.org> Content-Language: en-US From: Milan Broz Autocrypt: addr=gmazyland@gmail.com; keydata= xsFNBE94p38BEADZRET8y1gVxlfDk44/XwBbFjC7eM6EanyCuivUPMmPwYDo9qRey0JdOGhW hAZeutGGxsKliozmeTL25Z6wWICu2oeY+ZfbgJQYHFeQ01NVwoYy57hhytZw/6IMLFRcIaWS Hd7oNdneQg6mVJcGdA/BOX68uo3RKSHj6Q8GoQ54F/NpCotzVcP1ORpVJ5ptyG0x6OZm5Esn 61pKE979wcHsz7EzcDYl+3MS63gZm+O3D1u80bUMmBUlxyEiC5jo5ksTFheA8m/5CAPQtxzY vgezYlLLS3nkxaq2ERK5DhvMv0NktXSutfWQsOI5WLjG7UWStwAnO2W+CVZLcnZV0K6OKDaF bCj4ovg5HV0FyQZknN2O5QbxesNlNWkMOJAnnX6c/zowO7jq8GCpa3oJl3xxmwFbCZtH4z3f EVw0wAFc2JlnufR4dhaax9fhNoUJ4OSVTi9zqstxhEyywkazakEvAYwOlC5+1FKoc9UIvApA GvgcTJGTOp7MuHptHGwWvGZEaJqcsqoy7rsYPxtDQ7bJuJJblzGIUxWAl8qsUsF8M4ISxBkf fcUYiR0wh1luUhXFo2rRTKT+Ic/nJDE66Ee4Ecn9+BPlNODhlEG1vk62rhiYSnyzy5MAUhUl stDxuEjYK+NGd2aYH0VANZalqlUZFTEdOdA6NYROxkYZVsVtXQARAQABzSBNaWxhbiBCcm96 IDxnbWF6eWxhbmRAZ21haWwuY29tPsLBlQQTAQgAPwIbAwYLCQgHAwIGFQgCCQoLBBYCAwEC HgECF4AWIQQqKRgkP95GZI0GhvnZsFd72T6Y/AUCYaUUZgUJJPhv5wAKCRDZsFd72T6Y/D5N D/438pkYd5NyycQ2Gu8YAjF57Od2GfeiftCDBOMXzh1XxIx7gLosLHvzCZ0SaRYPVF/Nr/X9 sreJVrMkwd1ILNdCQB1rLBhhKzwYFztmOYvdCG9LRrBVJPgtaYqO/0493CzXwQ7FfkEc4OVB uhBs4YwFu+kmhh0NngcP4jaaaIziHw/rQ9vLiAi28p1WeVTzOjtBt8QisTidS2VkZ+/iAgqB 9zz2UPkE1UXBAPU4iEsGCVXGWRz99IULsTNjP4K3p8ZpdZ6ovy7X6EN3lYhbpmXYLzZ3RXst PEojSvqpkSQsjUksR5VBE0GnaY4B8ZlM3Ng2o7vcxbToQOsOkbVGn+59rpBKgiRadRFuT+2D x80VrwWBccaph+VOfll9/4FVv+SBQ1wSPOUHl11TWVpdMFKtQgA5/HHldVqrcEssWJb9/tew 9pqxTDn6RHV/pfzKCspiiLVkI66BF802cpyboLBBSvcDuLHbOBHrpC+IXCZ7mgkCrgMlZMql wFWBjAu8Zlc5tQJPgE9eeQAQrfZRcLgux88PtxhVihA1OsMNoqYapgMzMTubLUMYCCsjrHZe nzw5uTcjig0RHz9ilMJlvVbhwVVLmmmf4p/R37QYaqm1RycLpvkUZUzSz2NCyTcZp9nM6ooR GhpDQWmUdH1Jz9T6E9//KIhI6xt4//P15ZfiIs7BTQRPeKd/ARAA3oR1fJ/D3GvnoInVqydD U9LGnMQaVSwQe+fjBy5/ILwo3pUZSVHdaKeVoa84gLO9g6JLToTo+ooMSBtsCkGHb//oiGTU 7KdLTLiFh6kmL6my11eiK53o1BI1CVwWMJ8jxbMBPet6exUubBzceBFbmqq3lVz4RZ2D1zKV njxB0/KjdbI53anIv7Ko1k+MwaKMTzO/O6vBmI71oGQkKO6WpcyzVjLIip9PEpDUYJRCrhKg hBeMPwe+AntP9Om4N/3AWF6icarGImnFvTYswR2Q+C6AoiAbqI4WmXOuzJLKiImwZrSYnSfQ 7qtdDGXWYr/N1+C+bgI8O6NuAg2cjFHE96xwJVhyaMzyROUZgm4qngaBvBvCQIhKzit61oBe I/drZ/d5JolzlKdZZrcmofmiCQRa+57OM3Fbl8ykFazN1ASyCex2UrftX5oHmhaeeRlGVaTV iEbAvU4PP4RnNKwaWQivsFhqQrfFFhvFV9CRSvsR6qu5eiFI6c8CjB49gBcKKAJ9a8gkyWs8 sg4PYY7L15XdRn8kOf/tg98UCM1vSBV2moEJA0f98/Z48LQXNb7dgvVRtH6owARspsV6nJyD vktsLTyMW5BW9q4NC1rgQC8GQXjrQ+iyQLNwy5ESe2MzGKkHogxKg4Pvi1wZh9Snr+RyB0Rq rIrzbXhyi47+7wcAEQEAAcLBfAQYAQgAJgIbDBYhBCopGCQ/3kZkjQaG+dmwV3vZPpj8BQJh pRSXBQkk+HAYAAoJENmwV3vZPpj8BPMP/iZV+XROOhs/MsKd7ngQeFgETkmt8YVhb2Rg3Vgp AQe9cn6aw9jk3CnB0ecNBdoyyt33t3vGNau6iCwlRfaTdXg9qtIyctuCQSewY2YMk5AS8Mmb XoGvjH1Z/irrVsoSz+N7HFPKIlAy8D/aRwS1CHm9saPQiGoeR/zThciVYncRG/U9J6sV8XH9 OEPnQQR4w/V1bYI9Sk+suGcSFN7pMRMsSslOma429A3bEbZ7Ikt9WTJnUY9XfL5ZqQnjLeRl 8243OTfuHSth26upjZIQ2esccZMYpQg0/MOlHvuFuFu6MFL/gZDNzH8jAcBrNd/6ABKsecYT nBInKH2TONc0kC65oAhrSSBNLudTuPHce/YBCsUCAEMwgJTybdpMQh9NkS68WxQtXxU6neoQ U7kEJGGFsc7/yXiQXuVvJUkK/Xs04X6j0l1f/6KLoNQ9ep/2In596B0BcvvaKv7gdDt1Trgg vlB+GpT+iFRLvhCBe5kAERREfRfmWJq1bHod/ulrp/VLGAaZlOBTgsCzufWF5SOLbZkmV2b5 xy2F/AU3oQUZncCvFMTWpBC+gO/o3kZCyyGCaQdQe4jS/FUJqR1suVwNMzcOJOP/LMQwujE/ Ch7XLM35VICo9qqhih4OvLHUAWzC5dNSipL+rSGHvWBdfXDhbezJIl6sp7/1rJfS8qPs In-Reply-To: <20250709190902.49554-1-ebiggers@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/9/25 9:09 PM, Eric Biggers wrote: > The support for asynchronous hashes in dm-verity has outlived its > usefulness. It adds significant code complexity and opportunity for > bugs. I don't know of anyone using it in practice. (The original > submitter of the code possibly was, but that was 8 years ago.) Data I > recently collected for en/decryption shows that using off-CPU crypto > "accelerators" is consistently much slower than the CPU > (https://lore.kernel.org/r/20250704070322.20692-1-ebiggers@kernel.org/), > even on CPUs that lack dedicated cryptographic instructions. Similar > results are likely to be seen for hashing. > > I already removed support for asynchronous hashes from fsverity two > years ago, and no one ever complained. > > Moreover, neither dm-verity, fsverity, nor fscrypt has ever actually > used the asynchronous crypto algorithms in a truly asynchronous manner. > The lack of interest in such optimizations provides further evidence > that it's only the CPU-based crypto that actually matters. > > Historically, it's also been common for people to forget to enable the > optimized SHA-256 code, which could contribute to an off-CPU crypto > engine being perceived as more useful than it really is. In 6.16 I > fixed that: the optimized SHA-256 code is now enabled by default. > > Therefore, let's drop the support for asynchronous hashes in dm-verity. > > Tested with verity-compat-test. Hi, I shortly tested it with veritysetup too, also on 32bit. And I like this patch (I wish we can remove the async thing from the dmcrypt too...) Just one nitpick - could you please increase minor version of dm-verity target, so we have information in debug log that it is a patched version? Thanks, Milan > > Acked-by: Ard Biesheuvel > Signed-off-by: Eric Biggers > --- > > Changed in v2: > - Removed the now-unused 'may_sleep' parameter from verity_hash() > - Fixed a typo in commit message > - Added comment in verity_setup_salt_and_hashstate() > - Keep SHASH_DESC_ON_STACK in existing place in > verity_setup_salt_and_hashstate(), to reduce the diff slightly > - Added Ard's Acked-by > > drivers/md/dm-verity-fec.c | 4 +- > drivers/md/dm-verity-target.c | 183 ++++++---------------------------- > drivers/md/dm-verity.h | 22 ++-- > 3 files changed, 37 insertions(+), 172 deletions(-)