From: "cron2 (Code Review)" Date: Tue, 20 May 2025 20:43:49 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., sasepp@...2783... Message-ID: <1f1b159de7471b4cb7e92f1f5bcad7fdd0909c30-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="2qwQMtGpfFg="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: t_server_null: print error when server startup fails List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mattock Cc: flichtenheld , plaisthos , openvpn-devel --2qwQMtGpfFg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, mattock, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/1024?usp=3Demail ) Change subject: t_server_null: print error when server startup fails ...................................................................... Patch Set 1: (1 comment) File tests/t_server_null_server.sh: http://gerrit.openvpn.net/c/openvpn/+/1024/comment/10e6f7d1_701a039c : PS1, Line 27: # we run OpenVPN without --daemon and --log to catch the = underlying error. > I can't remember the impact of --log, so I need to test again. [=E2=80=A6] This is correct, if cli parsing fails before logging is changed, you'll onl= y see stdout/stderr Which is why t_client.sh uses ``` $RUN_SUDO "${openvpn}" $openvpn_conf >>$LOGDIR/$SUF:openvpn.log & ``` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1024?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I39dc6b08952a06dae7901e468f9487c8541d83c3 Gerrit-Change-Number: 1024 Gerrit-PatchSet: 1 Gerrit-Owner: mattock Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: cron2 Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: mattock Gerrit-Comment-Date: Tue, 20 May 2025 20:43:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Comment-In-Reply-To: mattock Gerrit-MessageType: comment --2qwQMtGpfFg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, mattock, plaisthos.=

View = Change

1 comment:

    =
  • File tests/t_server_null_server.sh:=

    • Patch Set #1, Lin= e 27: # we run Open= VPN without --daemon and --log to catch the underlying error.

      =

      I can't remember the impact of --log, so I need to test again.= [=E2=80=A6]

      This is correct, if cli parsing fails before logging is change= d, you'll only see stdout/stderr

      Which is why t_client.sh uses

      ```
      $RUN_SUDO = "${openvpn}" $openvpn_conf >>$LOGDIR/$SUF:openvpn.log &=
      ```

To view, visit change 1024. To unsubscribe,= or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I39dc6b08952a06dae7901e468f9= 487c8541d83c3
Gerrit-Change-Number: 1024
Gerrit-PatchSet: 1
Gerrit-Owner: mattock <sasepp@...2783...>= ;
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: cron2 <gert@...1296...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: mattock <sasepp@...2867...= .>
Gerrit-Comment-Date: Tue, 20 May 2025 20:43:49= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
Comment-In-Reply-To: mattock <sasepp@...2283...= 3...>
Gerrit-MessageType: comment
--2qwQMtGpfFg=--