Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1p9nuB-0004Bo-FC for mharc-qemu-riscv@gnu.org; Mon, 26 Dec 2022 08:52:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p9nuA-0004BS-AI for qemu-riscv@nongnu.org; Mon, 26 Dec 2022 08:52:38 -0500 Received: from mail-oa1-x36.google.com ([2001:4860:4864:20::36]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p9nu8-0004t2-Hg for qemu-riscv@nongnu.org; Mon, 26 Dec 2022 08:52:37 -0500 Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-1322d768ba7so12660077fac.5 for ; Mon, 26 Dec 2022 05:52:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ILG8/KA0rUbkqz10+1hrBDXU7jbLvP8SSswKIjjvFZo=; b=Bb3OYid0CV3FzEEJ4eQasC4UtVoZOOPifaaywNQAULZRJeeJiRfCRPmKDstBjNCrBI MTsKMan5orS+O9iVZD+yi27tEpi8QE8Lxc1ntOnyXFTVa9log/UBJpnaRpvcBcti2wG5 4kDqO1/gYqvWrj0R1u8tJFtGt4Guii0RhZg6av7NClOrDFhsEtxArpocaSnUbKkks5V8 AUZwud1PrhnYWmWCETErrGXu+QqejXA/9NqkT4Xtg0r9zmPR3ybLCx2ALuAwSB986WUh tqxBXyGgUPQUjZh17jDfUWXfMDtDpOeEuUHAlNFqEQCt99hoUK5MvOVvtdvSf/psjnMX ngYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ILG8/KA0rUbkqz10+1hrBDXU7jbLvP8SSswKIjjvFZo=; b=brKJf7Y6odjCvvmaGo0IcokF/n2gPAJIo0hYnWhseK1D90kjQSTb7OHCWb3fiIC9EF GsLou87W1DGzWFiQuNatKktmjU3bmKfX1LvsDVDGyo+UaMxUgnaNdgA3mdzMbaR8i7WW 3ZsxG8xYAL8WzjZU1Gi3bH8SUz4OUk3X4NqFJ8gSuEk3ZxN4qjE8thUYmPmMV/JNWtUo yECzETFs3E7irEyoKz/dBA0qV2hdxm1Wl9FmONSctrDzunD+/Pncd0LS9uSawltvThRE U1tgTA5pb2uKcm/kjxG4V3LKabP5hC5HsU+VHKeIxvT7OIZhzElIv1I3pqYwom691Ar2 1RjA== X-Gm-Message-State: AFqh2kofE7v1swCj7qbfcXm4UM1/e49v4+GoMQI/p9L493ls4ymoUj9s f8Vhxxbjzb7icWXbh+fUq7gm9g== X-Google-Smtp-Source: AMrXdXuOIM0uMD6odT/zbElKoZVBROAa9iJJpwrwE0/CtlOrBR7GiatAkAg0qVdWnCjuUwaQf3O0Ag== X-Received: by 2002:a05:6870:2f01:b0:144:e6fb:b2b4 with SMTP id qj1-20020a0568702f0100b00144e6fbb2b4mr8310786oab.20.1672062753429; Mon, 26 Dec 2022 05:52:33 -0800 (PST) Received: from [192.168.68.107] ([177.102.70.162]) by smtp.gmail.com with ESMTPSA id k16-20020a056870d39000b00132741e966asm4910867oag.51.2022.12.26.05.52.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Dec 2022 05:52:32 -0800 (PST) Message-ID: <1f93616e-3d12-3f86-2267-e13c2416754e@ventanamicro.com> Date: Mon, 26 Dec 2022 10:52:29 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 06/15] hw/riscv/spike.c: load initrd right after riscv_load_kernel() Content-Language: en-US To: Bin Meng Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org, alistair.francis@wdc.com, Bin Meng References: <20221221182300.307900-1-dbarboza@ventanamicro.com> <20221221182300.307900-7-dbarboza@ventanamicro.com> From: Daniel Henrique Barboza In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2001:4860:4864:20::36; envelope-from=dbarboza@ventanamicro.com; helo=mail-oa1-x36.google.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.147, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Dec 2022 13:52:38 -0000 On 12/26/22 10:49, Bin Meng wrote: > On Fri, Dec 23, 2022 at 6:04 PM Bin Meng wrote: >> On Thu, Dec 22, 2022 at 2:28 AM Daniel Henrique Barboza >> wrote: >>> This will make the code more in line with what the other boards are >>> doing. We'll also avoid an extra check to machine->kernel_filename since >>> we already checked that before executing riscv_load_kernel(). >>> >>> Signed-off-by: Daniel Henrique Barboza >>> --- >>> hw/riscv/spike.c | 31 +++++++++++++++---------------- >>> 1 file changed, 15 insertions(+), 16 deletions(-) >>> >> Reviewed-by: Bin Meng > This change unfortunately breaks the ELF boot on Spike. > > I will propose a patch to fix such unexpected dependency. Interesting.  This is one of the most benign changes I did, or so I thought. I believe we should wait for you patch fixing it first. Daniel > > Regards, > Bin