Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=quantatw.com (client-ip=220.128.79.91; helo=mx02.quantatw.com; envelope-from=prvs=983ff241d=hank.liou@quantatw.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=quantatw.com Received: from mx02.quantatw.com (mx02.quantatw.com [220.128.79.91]) by lists.ozlabs.org (Postfix) with ESMTP id 44VMG24lRqzDqNg for ; Thu, 28 Mar 2019 21:54:55 +1100 (AEDT) Received: from unknown (HELO mailbx05.quanta.corp) ([10.243.91.100]) by mx02.quantatw.com with ESMTP; 28 Mar 2019 18:54:52 +0800 Received: from mailbx05.quanta.corp (10.243.91.100) by mailbx05.quanta.corp (10.243.91.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 28 Mar 2019 18:54:51 +0800 Received: from mailbx05.quanta.corp ([fe80::34d4:593b:40f8:a9bc]) by mailbx05.quanta.corp ([fe80::34d4:593b:40f8:a9bc%4]) with mapi id 15.01.1713.004; Thu, 28 Mar 2019 18:54:51 +0800 From: =?big5?B?SGFuayBMaW91ICi8Qq7Kv6sp?= To: "openbmc@lists.ozlabs.org" Subject: [phosphor-pid-control] scaling issue Thread-Topic: [phosphor-pid-control] scaling issue Thread-Index: AQHU5Sj9loI9dbbDpkixezz7G113kw== Date: Thu, 28 Mar 2019 10:54:51 +0000 Message-ID: <1f94cb30fe624740b2ad67438b643266@quantatw.com> Accept-Language: en-US, zh-TW Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.243.91.252] Content-Type: multipart/alternative; boundary="_000_1f94cb30fe624740b2ad67438b643266quantatwcom_" MIME-Version: 1.0 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Mar 2019 10:55:07 -0000 --_000_1f94cb30fe624740b2ad67438b643266quantatwcom_ Content-Type: text/plain; charset="big5" Content-Transfer-Encoding: base64 SGkgQWxsLA0KDQoNClRoaXMgaXNzdWUgaXMgcmVsYXRlZCB0byB0aGUgcmVwb3NpdG9yeSBwaG9z cGhvci1waWQtY29udHJvbDxodHRwczovL2dpdGh1Yi5jb20vb3BlbmJtYy9waG9zcGhvci1waWQt Y29udHJvbD4uDQoNCg0KSXQgaXMgaW4gY29tbWl0IGRidXNwYXNzaXZlOiBhbGxvdyBzY2FsaW5n PGh0dHBzOi8vZ2l0aHViLmNvbS9vcGVuYm1jL3Bob3NwaG9yLXBpZC1jb250cm9sL2NvbW1pdC83 NWViNzY5ZDM1MTQzNDU0Nzg5OTE4NmY3M2ZmNzBhZTAwZDc5MzRhPiB0aGF0IG9uZSBhZGRlZCBz Y2FsaW5nIG1lY2hhbmlzbS4gSG93ZXZlciB3aGVuIGl0IGNvbWVzIHRvIHBpZC5jcHA8aHR0cHM6 Ly9naXRodWIuY29tL29wZW5ibWMvcGhvc3Bob3ItcGlkLWNvbnRyb2wvYmxvYi9tYXN0ZXIvcGlk L2VjL3BpZC5jcHA+LCBpdCBtYXkgZW5jb3VudGVyIHNjYWxpbmcgbWlzbWF0Y2guIFRoYXQgaXMg dG8gc2F5LCAoaW4gZmFuIGNvbnRyb2wgc3RhZ2UpIHRoZSBwaWQgdGFrZXMgdGhlIHNjYWxlZCB2 YWx1ZXMgYXMgaW5wdXRzLCBidXQgaXQgdXRpbGl6ZXMgdW5zY2FsZWQgc2V0cG9pbnRzIHJlc3Vs dGluZyB3cm9uZyBlcnJvciB0ZXJtcy4gT3IganVzdCBjaGFuZ2UgdGhlIHNldHBvaW50IHZhbHVl Pw0KDQoNClRoYW5rcywNCg0KDQpIYW5rIExpb3UNCg0KUXVhbnRhIENvbXB1dGVyIEluYy4NCg== --_000_1f94cb30fe624740b2ad67438b643266quantatwcom_ Content-Type: text/html; charset="big5" Content-Transfer-Encoding: quoted-printable

Hi All,


This issue is related to the repository phosphor-pid-control.


It is in commit dbuspassive: allow scaling that one added scaling m= echanism. However when it comes to pid.cpp, it may encounter scaling mismatch. That is to say, (in fan con= trol stage) the pid takes the scaled values as inputs, but it utilizes= unscaled setpoints resulting wrong error terms. Or just ch= ange the setpoint value?


Thanks,


Hank Liou

Quanta Computer Inc.

--_000_1f94cb30fe624740b2ad67438b643266quantatwcom_--