From: Sergey Vlasov Subject: Re: [PATCH] Add proper module ID tables to Adaptec aic7[9x]xx drivers Date: Mon, 21 Jun 2004 20:10:47 +0400 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <20040621161047.GD16453@master.mivlgu.local> References: <20040621161441.20dfcee6.ak@suse.de> <20040621174408.012aa366.vsu@altlinux.ru> <20040621182440.0743036f.ak@suse.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="llIrKcgUOe3dCx0c" Return-path: Received: from mivlgu.ru ([81.18.140.87]:42152 "EHLO master.mivlgu.local") by vger.kernel.org with ESMTP id S266297AbUFUQKt (ORCPT ); Mon, 21 Jun 2004 12:10:49 -0400 Content-Disposition: inline In-Reply-To: <20040621182440.0743036f.ak@suse.de> List-Id: linux-scsi@vger.kernel.org To: Andi Kleen Cc: linux-scsi@vger.kernel.org --llIrKcgUOe3dCx0c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 21, 2004 at 06:24:40PM +0200, Andi Kleen wrote: > On Mon, 21 Jun 2004 17:44:08 +0400 > Sergey Vlasov wrote: > > > On Mon, 21 Jun 2004 16:14:41 +0200 Andi Kleen wrote: > > > > > This is needed for 2.6 hotplug where the driver is autoloaded. When you have > > > multiple conflicting entries the hotplug module loader usually loads > > > the first one listed, which may be correct or may be not. > > > > > > With these changes the drivers announce the correct PCI IDs. > > > > Unfortunately, the patch does not seem to be correct :( > > > > struct pci_device_id does not have the mask field, therefore the > > ID_9005_GENERIC_MASK restriction cannot be specified other than by > > listing all 16 possible IDs as separate entries. Your patch adds only > > one entry, thus losing 15 other possible IDs. > > Hmm, good point. Thanks for catching this. > > Here is a new patch. Does this one look better? It fixes the above problem, but it's hard to say that the patch is correct without carefully checking all the tables. I'm trying to hack up something to autogenerate the pci_device_id table from the aic7xxx internal table. BTW, ID_AIC7810 and ID_AIC7815 probably should not be in the PCI ID table at all - ahc_raid_setup() just prints "RAID functionality unsupported" for them. And some more IDs generated by ID16 are really rejected by the driver due to the (ID_9005_SISL_ID, ID_9005_SISL_MASK) exclusion entry. --llIrKcgUOe3dCx0c Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQFA1wiHW82GfkQfsqIRAsPDAJ0UWS0Ap8Kl3xEPloPbjnDMRtnPdwCgj2ax uD1bbv5+RTke8Qmk4ZF8eWI= =1yFe -----END PGP SIGNATURE----- --llIrKcgUOe3dCx0c--