From: Andrew Morton Subject: Re: Fw: Re: Process hangs copying large file to cifs filesystem Date: Fri, 25 Jun 2004 12:39:34 -0700 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <20040625123934.03573f0f.akpm@osdl.org> References: <20040625012931.16e4c7f5.akpm@osdl.org> <20040625145234.GN12308@parcelfarce.linux.theplanet.co.uk> <20040625113214.3324d830.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: viro@parcelfarce.linux.theplanet.co.uk, sfrench@us.ibm.com, linux-fsdevel@vger.kernel.org Return-path: Received: from fw.osdl.org ([65.172.181.6]:49307 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S265354AbUFYTku (ORCPT ); Fri, 25 Jun 2004 15:40:50 -0400 To: Linus Torvalds In-Reply-To: List-Id: linux-fsdevel.vger.kernel.org Linus Torvalds wrote: > > > > On Fri, 25 Jun 2004, Andrew Morton wrote: > > > > Linus, why does __mark_inode_dirty() skip unhashed inodes? > > Hah. I wouldn't remember for the life of me. There could be multiple > reasons, all of which I've forgotten: > > - ramfs deadlocks on "sync()", since it can't write out inodes hm. ramfs oopses on null ->writepage without the check. I'll fix that up. > - stale and bad inodes get unhashed, and end up being unwritable. Maybe we should check inode sanity in the writing path, rather than the dirtying path. We already check is_bad_inode() in write_inode(). > - totally stale reason that doesn't exist any more. > > I suspect #3 migth well be true, but it's a scary change to try. It is indeed scary, yes. I think the path of least resistance here is for cifs to start hashing dem inodes.