From: Andrew Morton Subject: Re: Fw: Re: Process hangs copying large file to cifs filesystem Date: Fri, 25 Jun 2004 16:52:59 -0700 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <20040625165259.2686c756.akpm@osdl.org> References: <20040625123934.03573f0f.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, torvalds@osdl.org, viro@parcelfarce.linux.theplanet.co.uk Return-path: Received: from fw.osdl.org ([65.172.181.6]:43999 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S266894AbUFYXuI (ORCPT ); Fri, 25 Jun 2004 19:50:08 -0400 To: Steven French In-Reply-To: List-Id: linux-fsdevel.vger.kernel.org Steven French wrote: > > > It is indeed scary, yes. I think the path of least resistance here is > for > > cifs to start hashing dem inodes. > > Yes, agreed. I will test that minor change, to call insert_inode_hash to > new cifs inodes, this weekend. > Great, thanks. Other things: - cifs_commit_write() should be running set_page_dirty() in the !PageUptodate() case as well, yes? - Currently, a cifs set_page_dirty() falls into __set_page_dirty_buffers(). That's OK, but incurs more locking than is needed. Suggest you make cifs_addr_ops.set_page_dirty point at __set_page_dirty_nobuffers().