From: akpm@osdl.org Subject: [patch 4/6] cifs_setattr() retval fix Date: Sat, 26 Jun 2004 15:00:37 -0700 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <200406262201.i5QM1WZ06730@mail.osdl.org> Cc: shaggy@austin.ibm.com, sfrench@us.ibm.com, vandrove@vc.cvut.cz, zippel@linux-m68k.org, agruen@suse.de, linux-fsdevel@vger.kernel.org, akpm@osdl.org Return-path: Received: from fw.osdl.org ([65.172.181.6]:3468 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S266474AbUFZWCi (ORCPT ); Sat, 26 Jun 2004 18:02:38 -0400 To: mason@suse.com List-Id: linux-fsdevel.vger.kernel.org CIFS is failing to propagate the inode_setattr() return value. Signed-off-by: Andrew Morton --- 25-akpm/fs/cifs/inode.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletion(-) diff -puN fs/cifs/inode.c~cifs_setattr-retval-fix fs/cifs/inode.c --- 25/fs/cifs/inode.c~cifs_setattr-retval-fix 2004-06-26 14:42:54.386081584 -0700 +++ 25-akpm/fs/cifs/inode.c 2004-06-26 14:43:16.864664320 -0700 @@ -954,7 +954,8 @@ cifs_setattr(struct dentry *direntry, st } /* do not need local check to inode_check_ok since the server does that */ - inode_setattr(direntry->d_inode, attrs); + if (!rc) + rc = inode_setattr(direntry->d_inode, attrs); if (full_path) kfree(full_path); FreeXid(xid); _