From: Andreas Gruenbacher Subject: Re: [patch 6/6] affs_setattr() retval fix Date: Sun, 27 Jun 2004 00:46:15 +0200 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <200406270046.15345.agruen@suse.de> References: <200406262201.i5QM1fZ06740@mail.osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: mason@suse.com, shaggy@austin.ibm.com, sfrench@us.ibm.com, vandrove@vc.cvut.cz, zippel@linux-m68k.org, linux-fsdevel@vger.kernel.org Return-path: Received: from cantor.suse.de ([195.135.220.2]:56539 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S266489AbUFZWoE (ORCPT ); Sat, 26 Jun 2004 18:44:04 -0400 To: akpm@osdl.org In-Reply-To: <200406262201.i5QM1fZ06740@mail.osdl.org> Content-Disposition: inline List-Id: linux-fsdevel.vger.kernel.org On Sunday 27 June 2004 00:00, akpm@osdl.org wrote: > affs is failing to propagate the inode_setattr() return value. > > Signed-off-by: Andrew Morton > --- > > 25-akpm/fs/affs/inode.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletion(-) > > diff -puN fs/affs/inode.c~affs_setattr-retval-fix fs/affs/inode.c > --- 25/fs/affs/inode.c~affs_setattr-retval-fix 2004-06-26 > 14:46:27.538677464 -0700 +++ 25-akpm/fs/affs/inode.c 2004-06-26 > 14:46:40.798661640 -0700 > @@ -249,7 +249,8 @@ affs_notify_change(struct dentry *dentry > goto out; > } > > - inode_setattr(inode, attr); > + if (!error) > + error = inode_setattr(inode, attr); > if (!error && (attr->ia_valid & ATTR_MODE)) > mode_to_prot(inode); > out: > _ This should be enough here: --- linux-2.6.5.orig/fs/affs/inode.c +++ linux-2.6.5/fs/affs/inode.c @@ -251,3 +251,3 @@ - inode_setattr(inode, attr); + error = inode_setattr(inode, attr); if (!error && (attr->ia_valid & ATTR_MODE)) Cheers, -- Andreas Gruenbacher SUSE Labs, SUSE LINUX AG