From: Andrew Morton Subject: Re: inode->i_flags locking Date: Thu, 1 Jul 2004 15:02:36 -0700 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <20040701150236.7d2f5577.akpm@osdl.org> References: <20040626141941.71adaec4.akpm@osdl.org> <20040701200356.GD3540@atrey.karlin.mff.cuni.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org Return-path: Received: from fw.osdl.org ([65.172.181.6]:14797 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S266314AbUGAV7o (ORCPT ); Thu, 1 Jul 2004 17:59:44 -0400 To: Jan Kara In-Reply-To: <20040701200356.GD3540@atrey.karlin.mff.cuni.cz> List-Id: linux-fsdevel.vger.kernel.org Jan Kara wrote: > > > What protects inode->i_flags? > > > > - During read_inode() nobody can see the inode anyway > > > > - fs/namei.c uses i_sem (which seems appropriate) > > > > - fs/dquot.c doesn't seem to use i_sem? > Here is a patch which fixes the bug. It gets rather a large reject due to post-2.6.7 changes in remove_dquot_ref(). Could you fix that up please?