From: viro@parcelfarce.linux.theplanet.co.uk Subject: Re: [PATCH] Remove fcntl f_op Date: Thu, 12 Aug 2004 23:22:48 +0100 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <20040812222248.GS12308@parcelfarce.linux.theplanet.co.uk> References: <20040812221229.GH12936@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linus Torvalds , Andrew Morton , linux-fsdevel@vger.kernel.org, Steve French , Trond Myklebust Return-path: Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:47847 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S268840AbUHLWWt (ORCPT ); Thu, 12 Aug 2004 18:22:49 -0400 To: Matthew Wilcox Content-Disposition: inline In-Reply-To: <20040812221229.GH12936@parcelfarce.linux.theplanet.co.uk> List-Id: linux-fsdevel.vger.kernel.org On Thu, Aug 12, 2004 at 11:12:29PM +0100, Matthew Wilcox wrote: > > The newly introduced ->fcntl file_operation is badly thought out, > not to mention undocumented. This patch replaces it with two better > defined operations -- check_flags and dir_notify. Any other fcntl()s > that filesystems are interested in can have their own properly typed > f_op method when they need it. ACK