From: Matthew Wilcox Subject: Re: PATCH [6/10] lease interfaces for version 4 NFSD Date: Mon, 20 Sep 2004 21:33:58 +0100 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <20040920203358.GT642@parcelfarce.linux.theplanet.co.uk> References: <20040920202300.898BA1BBA3@citi.umich.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org Return-path: Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:30445 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S267330AbUITUeA (ORCPT ); Mon, 20 Sep 2004 16:34:00 -0400 To: "William A.(Andy) Adamson" Content-Disposition: inline In-Reply-To: <20040920202300.898BA1BBA3@citi.umich.edu> List-Id: linux-fsdevel.vger.kernel.org On Mon, Sep 20, 2004 at 04:23:00PM -0400, William A.(Andy) Adamson wrote: > + locks_init_lock(&fl); > + if ((error = lease_init(filp, arg, &fl))) > + return error; > + lock_kernel(); > + if((error = __setlease(filp, arg, &flp))) > + goto out; > + Please follow kernel coding style. That means: - Tabs, not spaces for indentation. - No assignment within if () - Space between if and ( ie write this bit as: locks_init_lock(&fl); error = lease_init(filp, arg, &fl); if (error) return error; lock_kernel(); error = __setlease(filp, arg, &flp); if (error) goto out; > return error; > } > > + > /** > * flock_lock_file_wait - Apply a FLOCK-style lock to a file > * @filp: The file to apply the lock to Don't put this additional line in. I don't like it. -- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain