From: Nishanth Aravamudan Date: Sat, 23 Oct 2004 00:01:12 +0000 Subject: [KJ] [PATCH] w1/w1_int: replace schedule_timeout() with Message-Id: <20041023000112.GQ18906@us.ibm.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="===============8324399442101007==" List-Id: To: kernel-janitors@vger.kernel.org --===============8324399442101007== Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Any comments would be, as always, appreciated. -Nish Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected. Signed-off-by: Nishanth Aravamudan --- 2.6.9-bk7-vanilla/drivers/w1/w1_int.c 2004-10-22 10:41:43.000000000 -0700 +++ 2.6.9-bk7/drivers/w1/w1_int.c 2004-10-22 16:07:31.000000000 -0700 @@ -184,10 +184,8 @@ void __w1_remove_master_device(struct w1 while (atomic_read(&dev->refcnt)) { printk(KERN_INFO "Waiting for %s to become free: refcnt=%d.\n", dev->name, atomic_read(&dev->refcnt)); - set_current_state(TASK_INTERRUPTIBLE); - schedule_timeout(HZ); - if (signal_pending(current)) + if (msleep_interruptible(1000)) flush_signals(current); } --===============8324399442101007== Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org http://lists.osdl.org/mailman/listinfo/kernel-janitors --===============8324399442101007==--