From: Wolfgang Denk Date: Wed, 12 Jan 2005 01:10:22 +0100 Subject: [U-Boot-Users] Patch: allow a fixed port for TFTP (take 3) In-Reply-To: Your message of "Tue, 11 Jan 2005 17:47:11 CST." <41E4657F.6010406@orkun.us> Message-ID: <20050112001027.30712C108D@atlas.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In message <41E4657F.6010406@orkun.us> you wrote: > > > I reject this because such a long variable name seems unacceptable to > > me. Don't make life unnecessarily hard to your users. Use a short > > name. How about "tftpport"? > > Wolfgang, "tftpport" is what he has done previously. :-( > I will pledge for clarity over 6 more bytes in environment which most > boards will not define anyway. If that is not reasonable, please allow > for "tftpsrcport" or "tftpcport". So be it "tftpsrcport" then. Or "tftpsrcp" :-) ["tftpcport" ??? TFT-PC-Port? Or 'c' like what???] > I actually want to provide a complimentary patch over this one to make > the tftp server port configurable which the environment variable can be > appropriately named as one of "tftpserverport", "tftpdestport" or tftpdstport or tftpdstp, please. > "tftpsport". I also want to use the same CONFIG_TFTP_PORT variable to [Seems to be some funny kind of exercise, this: TFTP sport. And is misleading - TFTP _S_ource Port ?] > enable both environment variables unless you object in which case naming > the config variables as CONFIG_TFTP_CLIENT_PORT and > CONFIG_TFTP_SERVER_PORT is probably better. OK. Best regards, Wolfgang Denk -- Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de They say, well, meybe it _is_ smelly, maybe it _is_ overcrowded, may- be it _is_ a bit like Hell would be if they shut the fires off and stabled a herd of incontinent cows there for a year, but you must admit that it is full of sheer, vibrant, dynamic _life_. - Terry Pratchett, _Moving Pictures_