From: Al Viro Subject: Re: [PATCH] factor out common code around ->follow_link invocation Date: Fri, 14 Jan 2005 00:38:04 +0000 Message-ID: <20050114003804.GL26051@parcelfarce.linux.theplanet.co.uk> References: <20050113165353.GB24377@lst.de> <20050113160634.0fd416b7.akpm@osdl.org> <20050114002121.GK26051@parcelfarce.linux.theplanet.co.uk> <20050113163449.61b1be2a.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: hch@lst.de, linux-fsdevel@vger.kernel.org Return-path: Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:57833 "EHLO parcelfarce.linux.theplanet.co.uk") by vger.kernel.org with ESMTP id S261732AbVANAiF (ORCPT ); Thu, 13 Jan 2005 19:38:05 -0500 To: Andrew Morton Content-Disposition: inline In-Reply-To: <20050113163449.61b1be2a.akpm@osdl.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Jan 13, 2005 at 04:34:49PM -0800, Andrew Morton wrote: > > > Now there's a fairly insane amount of inlining going on around > > > do_follow_link() and __do_follow_link(). It makes my fingers itchy. > > > > > > ow. __do_follow_link inlines __vfs_follow_link inlines walk_init_root and > > > __do_follow_link has maybe three callsites. > > > > No. These guys are in the middle of mutual recursion. So in this > > particular case we *do* need inlining. > > How can you do mutually-recursive code with inline functions > without generating an infinite amount of code? "In the middle of" != "entire" > Wanna spell it out a bit more please? link_path_walk -> do_follow_link -> __vfs_follow_link -> link_path_walk link_path_walk() is not inline. The rest of the thing would better be.