From: Jon Mason Subject: [PATCH 2/2] netfront skb padding Date: Tue, 8 Feb 2005 19:58:39 -0600 Message-ID: <200502081958.39478.jdmason@us.ibm.com> References: <200502081330.28743.jdmason@us.ibm.com> <200502081924.40908.jdmason@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit In-Reply-To: <200502081924.40908.jdmason@us.ibm.com> Content-Disposition: inline Sender: xen-devel-admin@lists.sourceforge.net Errors-To: xen-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Xen Mailing List List-Id: xen-devel@lists.xenproject.org It appears that when alloc'ing a skb, it is bring padded by an arbitrarily (and excessive) long value. The value for this padding really only needs to be 24. 24 = 14 for the ethernet header + 2 for the cache alignment + 4 for the CRC + 4 for the VLAN flags. Tested on Xen 2.0.3 and linux 2.6.10 kernel. Signed-off-by: Jon Mason --- --- drivers/xen/netfront/netfront.c.new 2005-02-08 19:09:31.368834000 -0600 +++ drivers/xen/netfront/netfront.c 2005-02-08 19:09:24.738834000 -0600 @@ -50,6 +50,8 @@ #include #include +#define NETFRONT_VERSION "1.1" + #ifndef __GFP_NOWARN #define __GFP_NOWARN 0 #endif @@ -62,8 +64,11 @@ skb_shinfo(_skb)->frag_list = NULL; \ } while (0) -/* Allow headroom on each rx pkt for Ethernet header, alignment padding, ... */ -#define RX_HEADROOM 200 +/* + * Allow headroom on each rx pkt for Ethernet header, alignment padding, + * CRC, and VLAN + */ +#define RX_HEADROOM ETH_HLEN + NET_IP_ALIGN + 8 /* * If the backend driver is pipelining transmit requests then we can be very @@ -1248,7 +1253,8 @@ static int __init netif_init(void) if (xen_start_info.flags & SIF_INITDOMAIN) return 0; - IPRINTK("Initialising virtual ethernet driver.\n"); + IPRINTK("Initialising virtual ethernet driver, version %s\n", + NETFRONT_VERSION); INIT_LIST_HEAD(&dev_list); (void)register_inetaddr_notifier(¬ifier_inetdev); netctrl_init(); ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click