From: Christoph Hellwig Subject: [PATCH] block new writers on frozen filesystems Date: Thu, 10 Feb 2005 17:13:31 +0100 Message-ID: <20050210161331.GA9001@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org Return-path: Received: from verein.lst.de ([213.95.11.210]:25305 "EHLO mail.lst.de") by vger.kernel.org with ESMTP id S262158AbVBJQNk (ORCPT ); Thu, 10 Feb 2005 11:13:40 -0500 To: akpm@osdl.org Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org When the lockfs patches went in an important bit got lost, the call in generic_file_write to put newly incoming writers to sleep when a filesystem is frozen. Nathan added back the call in the now separate XFS write patch, and the patch for the generic code is below: Index: mm/filemap.c =================================================================== RCS file: /cvs/linux-2.6-xfs/mm/filemap.c,v retrieving revision 1.14 diff -u -p -r1.14 filemap.c --- mm/filemap.c 5 Jan 2005 14:17:31 -0000 1.14 +++ mm/filemap.c 4 Feb 2005 21:35:53 -0000 @@ -2046,6 +2046,8 @@ __generic_file_aio_write_nolock(struct k count = ocount; pos = *ppos; + vfs_check_frozen(inode->i_sb, SB_FREEZE_WRITE); + /* We can write back this queue in page reclaim */ current->backing_dev_info = mapping->backing_dev_info; written = 0;