From: Al Viro Subject: Re: NFS4 mount problem Date: Mon, 18 Apr 2005 18:16:59 +0100 Message-ID: <20050418171659.GE13052@parcelfarce.linux.theplanet.co.uk> References: <20050417135521.GA6876@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , "David S. Miller" , dhowells@redhat.com, linux-fsdevel@vger.kernel.org, sfr@canb.auug.org.au, steved@redhat.com Return-path: Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:3482 "EHLO parcelfarce.linux.theplanet.co.uk") by vger.kernel.org with ESMTP id S262145AbVDRRRB (ORCPT ); Mon, 18 Apr 2005 13:17:01 -0400 To: Bryan Henderson Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Apr 18, 2005 at 10:07:14AM -0700, Bryan Henderson wrote: > >On Fri, Apr 15, 2005 at 01:22:59PM -0700, David S. Miller wrote: > >> > >> Make a ->compat_read_super() just like we have a ->compat_ioctl() > >> method for files, if you want to suggest a solution like what > >> you describe. > > > >I don't think we should encourage filesystem writers to do such stupid > >things as ncfps/smbfs do. In fact I'm totally unhappy thay nfs4 went > >down that road. > > Which road is that? Architecture-dependent blob passed to mount(2) (aka nfs4_mount_data). If you want it to be a blob, at least have a decency to use encoding that would not depend on alignment rules and word size. Hell, you could use XDR - it's not that nfs would need something new to handle it. Or, better yet, use a normal string.