From: Al Viro Subject: Re: NFS4 mount problem Date: Mon, 18 Apr 2005 18:43:38 +0100 Message-ID: <20050418174338.GG13052@parcelfarce.linux.theplanet.co.uk> References: <20050418171659.GE13052@parcelfarce.linux.theplanet.co.uk> <20050417135521.GA6876@infradead.org> <8310.1113845589@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Bryan Henderson , Christoph Hellwig , "David S. Miller" , linux-fsdevel@vger.kernel.org, sfr@canb.auug.org.au, steved@redhat.com Return-path: Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:5535 "EHLO parcelfarce.linux.theplanet.co.uk") by vger.kernel.org with ESMTP id S262141AbVDRRng (ORCPT ); Mon, 18 Apr 2005 13:43:36 -0400 To: David Howells Content-Disposition: inline In-Reply-To: <8310.1113845589@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Apr 18, 2005 at 06:33:09PM +0100, David Howells wrote: > Al Viro wrote: > > > > > Architecture-dependent blob passed to mount(2) (aka nfs4_mount_data). > > If you want it to be a blob, at least have a decency to use encoding > > that would not depend on alignment rules and word size. Hell, you > > could use XDR - it's not that nfs would need something new to handle > > it. Or, better yet, use a normal string. > > Mount doesn't appear to permit a big enough blob though. It has a hard limit > of PAGE_SIZE. Excuse me? Would the use of fixed offsets, field sizes and endianness make the blob bigger? And as for the length of string representation going past 4Kb... that could be easily dealt with in sys_mount() if it really becomes a problem.