From: Thomas Graf Subject: Re: [PATCH] update raw patch in POM Date: Wed, 22 Jun 2005 02:52:43 +0200 Message-ID: <20050622005243.GQ8335@postel.suug.ch> References: <42A6AB19.2040106@tac.ch> <42A6E685.3060408@eurodev.net> <42AEF774.8060300@tac.ch> <42B67BEC.1090105@tac.ch> <20050621003441.GI8335@postel.suug.ch> <42B76474.8080209@eurodev.net> <20050621111328.GK8335@postel.suug.ch> <42B81D75.8090205@trash.net> <20050621215027.GP8335@postel.suug.ch> <42B8B181.4020607@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Netfilter Developers , Pablo Neira , Roberto Nibali Return-path: To: Patrick McHardy Content-Disposition: inline In-Reply-To: <42B8B181.4020607@trash.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org * Patrick McHardy <42B8B181.4020607@trash.net> 2005-06-22 02:32 > Thomas Graf wrote:' > > This patch seems fine but it cannot fix the bug. The fact that we > > trigger the BUG() implies a serious problem which is that we'd be > > calling destroy() on a conntrack entry which was never allocated. > > Sorry, I didn't follow the entire thread and there seem to be a lot > of BUG()s :) Which one exactly are you refering to? Roberto added the following to nf_conntrack_put(): if ((((long) nfct) & 0xf8000000) && atomic_read(&nfct->master->use) <= 1) BUG(); The 0xf8.. really is a hack but it works on x86.