From: Asser =?iso-8859-1?Q?Fem=F8?= Subject: dnotify/inotify and vfs questions Date: Tue, 23 Aug 2005 15:00:23 +0200 Message-ID: <20050823130023.GB8305@diku.dk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OwLcNYc0lM97+oe1" Return-path: To: linux-cifs-client@lists.samba.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org --OwLcNYc0lM97+oe1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, I'm currently implementing change notification support for the linux cifs client as part of Google's Summer of Code program. In cifs, change notification works pretty much the same as dnotify does in the kernel, and you cancel the notification by sending a NT_CANCEL request.=20 According to the fcntl manual you can cancel a notification by doing fcntl(fd, F_NOTIFY, 0) (ie. sending 0 as the notification mask), but looking in the kernel code fcntl_dirnotify() immediately calls dnotify_flush() with neither telling the vfs module about it. Is there a reason for this? Otherwise I'd propose calling filp->f_op->dir_notify(filp, 0) at some point in this scenario. Regarding inotify, inotify_add_watch doesn't seem to pass on the request either, which works fine for local filesystem operations as they call fsnotify_* functions every time, but that isn't really feasible for filesystems like cifs because we'd have to request change notification on everything. Is there plans for implementing a mechanism to let vfs modules get watch requests too? cheers, Asser --OwLcNYc0lM97+oe1 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFDCx3ncbr5RuS4SGcRAlQaAJ9egZeZGVNB+eRGfH66AjYHMAbB+gCfYaDu qDFTyqi/ZYl1XXPN1woYaR4= =XJtS -----END PGP SIGNATURE----- --OwLcNYc0lM97+oe1--