From: Denis Vlasenko Subject: Re: I request inclusion of reiser4 in the mainline kernel Date: Sat, 17 Sep 2005 13:56:14 +0300 Message-ID: <200509171356.14497.vda@ilport.com.ua> References: <432AFB44.9060707@namesys.com> <432B1F84.3000902@namesys.com> <20050917092247.GA13992@infradead.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20050917092247.GA13992@infradead.org> Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-Id: Content-Type: text/plain; charset="us-ascii" To: Christoph Hellwig Cc: Hans Reiser , Andrew Morton , Linus Torvalds , LKML , ReiserFS List On Saturday 17 September 2005 12:22, Christoph Hellwig wrote: > On Fri, Sep 16, 2005 at 12:39:48PM -0700, Hans Reiser wrote: > > Christoph Hellwig wrote: > > > > >additinoal comment is that the code is very messy, very different > > >from normal kernel style, full of indirections and thus hard to read. > > > > > > > Most of my customers remark that Namesys code is head and shoulders > > above the rest of the kernel code. So yes, it is different. In > > particular, they cite the XFS code as being so incredibly hard to read > > that its unreadability is worth hundreds of thousands of dollars in > > license fees for me. That's cash received, from persons who read it > > all, not commentary made idly. > > It's very different from kernel style, and it's hard to read for us kernel > developers. And yes, I don't think XFS is the most easy to read code either, > quite contrary. But it's at least half a magnitude less bad than reiser4 > code.. At least reiser4 is smaller. IIRC xfs is older than reiser4 and had more time to optimize code size, but: reiser4 2557872 bytes xfs 3306782 bytes -- vda