From: Ewan Mellor Subject: Re: [PATCH 0/2] Change xs_read_watch interfaces to support variable arguments Date: Tue, 4 Oct 2005 07:55:36 +0100 Message-ID: <20051004065536.GA4104@linford.intra> References: <4342087F.5010505@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4342087F.5010505@us.ibm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Mon, Oct 03, 2005 at 11:43:43PM -0500, Anthony Liguori wrote: > The following set of changes modify the read_watch interface in > userspace and in the kernel to support variable arguments. This is in > preparation for adding domid to @{introduce,release}Domain watches. > This will allow backends to automatically reap on domain destruction > which should eliminate a large number of the zombie problems we're > having on domain destruction since Xend no longer plays a role in > freeing that memory. Hi Anthony, What you've done in your patch stands as a sensible thing on its own, I think, so I'm not objecting to that, but I am interested in why you think it will help with the zombies. On domain destruction, xend is _supposed_ to remove all the relevant entries of the store, and the backend drivers are _supposed_ to notice this and close themselves down. If you have evidence that either of those things aren't happening, then we should regard that as a bug, independent of your patch. Have you seen that happening? Ewan.